All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Johan Hovold <johan@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org,
	Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: keep the GPIO line names internal
Date: Mon, 5 Oct 2015 11:07:03 +0100	[thread overview]
Message-ID: <20151005100703.GC25143@localhost> (raw)
In-Reply-To: <20151005094704.GG19355@pengutronix.de>

On Mon, Oct 05, 2015 at 11:47:04AM +0200, Markus Pargmann wrote:
> On Sun, Oct 04, 2015 at 03:37:42PM +0200, Johan Hovold wrote:

> > You also need to revert ddd5404007b8 ("gpio-sysfs: Use gpio descriptor
> > name instead of gpiochip names array") however as this is an ABI change.  
> > Otherwise pins with a name in DT will now be exported using the gpio name
> > rather than number as they used to be. [ The current behaviour is
> > maintained by exporting names from chip->names for hard coded names
> > only. ]
> 
> Even for GPIOs from DT it is not a ABI change. The only GPIOs that have
> a GPIO name at the moment are using the GPIO hogging mechanism. But
> hogged GPIOs can't be exported to userspace so there is no difference
> for these.

Yes, but you're aiming at generalising the hogging mechanism so that
such pins can be requested, and that would break the ABI.

Let's keep the legacy chip->names and named-gpio exports separate from
defining line names in DT for now.

Thanks,
Johan

  reply	other threads:[~2015-10-05 10:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 23:27 [PATCH] gpio: keep the GPIO line names internal Linus Walleij
2015-09-24  7:40 ` Markus Pargmann
2015-09-24 16:47   ` Linus Walleij
2015-10-04 13:37 ` Johan Hovold
2015-10-05  8:54   ` Linus Walleij
2015-10-05 10:01     ` Johan Hovold
2015-10-05 11:07       ` Linus Walleij
2015-10-06  9:13         ` Markus Pargmann
2015-10-06 14:09           ` Johan Hovold
2015-10-16 14:41           ` Linus Walleij
2015-10-05  9:47   ` Markus Pargmann
2015-10-05 10:07     ` Johan Hovold [this message]
2015-10-05 10:19       ` Markus Pargmann
2015-10-05 11:10         ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005100703.GC25143@localhost \
    --to=johan@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.