From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Lidza Louina <lidza.louina@gmail.com>,
Daeseok Youn <daeseok.youn@gmail.com>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: dgap: remove unused configuration
Date: Mon, 5 Oct 2015 15:43:32 +0530 [thread overview]
Message-ID: <20151005101332.GA338@sudip-pc> (raw)
In-Reply-To: <20151005094643.GM7340@mwanda>
On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
> > other related variables defined for it.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>
> But say someone has an old config file with IO in it, doesn't this break
> their system?
No, it should not. dgap_parsefile() is executing a loop and reading
tokens from the configuration file and depending on what token it has
read it will do switch-case. And it will not find case IO: anymore and
will be just ignored (there is no default:).
And this is actually just a first step towards removing the
configuration file as Greg was telling that loading a firmware file and
consideing it as a configuartion file is not the right thing to do. So I
am removing all the unused configurations one at a time and after they
are removed then depending on the configurations left I will ask for
your suggestion how to remove the use of configuration file.
regards
sudip
prev parent reply other threads:[~2015-10-05 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 15:49 [PATCH] staging: dgap: remove unused configuration Sudip Mukherjee
2015-10-05 9:46 ` Dan Carpenter
2015-10-05 10:13 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005101332.GA338@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.