From: Karel Zak <kzak@redhat.com>
To: Priya Ahuja <priahuja321@gmail.com>
Cc: util-linux@vger.kernel.org, Ruediger Meier <ruediger.meier@ga-group.nl>
Subject: Re: Custom structured data from logger utility
Date: Mon, 5 Oct 2015 14:59:32 +0200 [thread overview]
Message-ID: <20151005125932.GA32529@ws.net.home> (raw)
In-Reply-To: <CAGQyBevj8+L6rMigOXQQw7t=iR9s-PMbbOLf40wu=P7212dCMw@mail.gmail.com>
On Fri, Oct 02, 2015 at 11:43:30AM -0700, Priya Ahuja wrote:
> Thanks for the changes. Is there a reason for keeping pre-set
> structured data elements like timeQuality, tzKnown if custom data is
> provided?
I don't think uses want to generate things like timeQuality by shell
on logger command line. IMHO "--sd-id timeQuality" will be used very
rarely (but it's possible and supported use case).
The another thing is that we already released logger with build-in
timeQuality and we have to keep it for backward compatibility.
> Also if the SD-ID is the same, it would make more sense
> merging the structured data into one, what do you think?
You have to use unique SD-ID and use it only once. It's pretty simple
semantic, I'm not sure if need something more complicated/complex.
(Or do you mean something else?)
For example:
--sd-id zoo@123 \
--sd-param tiger=\"hungry\" \
--sd-param zebra=\"running\" \
--sd-id manager@123 \
--sd-param onMeeting=\"yes\"
sd-id command line option works as separator between the elements, so
it generates two SD-ELEMENTS:
[zoo@123 tiger="hungry" zebra="running"]
[manager@123 onMeeting="yes"]
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-10-05 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 23:25 Custom structured data from logger utility Priya Ahuja
2015-09-19 8:50 ` Sami Kerola
2015-09-24 11:17 ` Karel Zak
2015-10-01 12:58 ` Karel Zak
2015-10-02 18:43 ` Priya Ahuja
2015-10-05 12:59 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005125932.GA32529@ws.net.home \
--to=kzak@redhat.com \
--cc=priahuja321@gmail.com \
--cc=ruediger.meier@ga-group.nl \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.