From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752287AbbJEPam (ORCPT ); Mon, 5 Oct 2015 11:30:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46437 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbbJEPal (ORCPT ); Mon, 5 Oct 2015 11:30:41 -0400 Date: Mon, 5 Oct 2015 16:30:36 +0100 From: Greg Kroah-Hartman To: "Winkler, Tomas" Cc: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" , Alexander Kuleshov Subject: Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output Message-ID: <20151005153036.GA16834@kroah.com> References: <1442822295-5111-1-git-send-email-tomas.winkler@intel.com> <20151004111906.GA23333@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B3D45F060@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3D45F060@hasmsx108.ger.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 02:47:35PM +0000, Winkler, Tomas wrote: > > > > On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote: > > > From: Alexander Kuleshov > > > > > > Signed-off-by: Alexander Kuleshov > > > Signed-off-by: Tomas Winkler > > > --- > > > V2: fixed author address > > > > > > drivers/misc/mei/debugfs.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c > > > index 4b469cf9e60f..c157f0ba575c 100644 > > > --- a/drivers/misc/mei/debugfs.c > > > +++ b/drivers/misc/mei/debugfs.c > > > @@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const > > char *name) > > > f = debugfs_create_file("active", S_IRUSR, dir, > > > dev, &mei_dbgfs_fops_active); > > > if (!f) { > > > - dev_err(dev->dev, "meclients: registration failed\n"); > > > + dev_err(dev->dev, "active: registration failed\n"); > > > goto err; > > > > You should never care if a debugfs call fails or not. > > The system should not be dependent on the debug feature but, it is > always good to know if there our system is failing And what can you do if it is "failing"? Really nothing, so there's nothing to check here. > Also, this will > > "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are > > using the api wrong :( > > The whole file is not compiled if CONFIG_DEBUGFS is not set, please see the Makefile Ok, then you don't need to check anything. Debugfs was created to be dirt-simple, don't add complexity and "must unwind cleanly" type logic here where it's not needed at all. That just hurts my sensibilities for why I made the API the way it is in the first place :) thanks, greg k-h