Re: [PATCH libmnl 1/2] socket: introduce mnl_socket_open2()

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Oct 02, 2015 at 10:12:33PM +0200, Guillaume Nault wrote:
> Define mnl_socket_open2() so that user can pass a set of SOCK_* flags
> at socket creation time.
> 
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
> ---
>  include/libmnl/libmnl.h |  3 ++-
>  src/libmnl.map          |  1 +
>  src/socket.c            | 41 ++++++++++++++++++++++++++++++++---------
>  3 files changed, 35 insertions(+), 10 deletions(-)
> 
> diff --git a/include/libmnl/libmnl.h b/include/libmnl/libmnl.h
> index 3a589bc..5adb13c 100644
> --- a/include/libmnl/libmnl.h
> +++ b/include/libmnl/libmnl.h
> @@ -21,7 +21,8 @@ extern "C" {
>  
>  struct mnl_socket;
>  
> -extern struct mnl_socket *mnl_socket_open(int type);
> +extern struct mnl_socket *mnl_socket_open(int bus);
> +extern struct mnl_socket *mnl_socket_open2(int bus, int flags);

Looks good, but we should be using 'unsigned int flags' instead, right?

Or am I missing anything?