From: Andi Kleen <ak@linux.intel.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Andrey Konovalov <andreyknvl@google.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Borislav Petkov <bp@alien8.de>,
Denys Vlasenko <dvlasenk@redhat.com>,
Sasha Levin <sasha.levin@oracle.com>,
Wolfram Gloger <wmglo@dent.med.uni-muenchen.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/process: Silence KASAN warnings in get_wchan()
Date: Mon, 5 Oct 2015 09:39:06 -0700 [thread overview]
Message-ID: <20151005163906.GE26924@tassilo.jf.intel.com> (raw)
In-Reply-To: <56126316.3030901@virtuozzo.com>
> But, I think I have the solution.
> We could have some blacklist - list of function names which we should be ignored.
> In kasan_report() we could resolve return address to function name and compare it with name in list.
> If name in list -> ignore report.
I think annotating statements is cleaner than functions, even if it
is more code. Much better documentation
But if you really want to annotate on the function level:
It's better to annotate the function directly than some hidden away list.
This way there is some indication that there are races in there, which is
generally useful documentation.
__racy_function or similar.
Also central lists are generally annoying as they cause patch conflicts.
If disabling with an attribute doesn't work, you could put it into a special section
with __attribute__((section ...)) and check the start/end symbol before reporting.
That's how kprobes solves similar issues. It also has the advantage
that it stops inlining.
-Andi
next prev parent reply other threads:[~2015-10-05 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 10:28 [PATCH] x86/process: Silence KASAN warnings in get_wchan() Andrey Ryabinin
2015-10-05 10:38 ` Dmitry Vyukov
2015-10-05 11:18 ` Borislav Petkov
2015-10-05 11:23 ` Ingo Molnar
2015-10-05 11:39 ` Dmitry Vyukov
2015-10-05 11:46 ` Andrey Ryabinin
2015-10-05 13:15 ` Borislav Petkov
2015-10-05 18:42 ` Andy Lutomirski
2015-10-05 16:39 ` Andi Kleen [this message]
2015-10-05 16:59 ` Andrey Ryabinin
2015-10-05 18:58 ` Andi Kleen
2015-10-06 7:26 ` Ingo Molnar
2015-10-06 7:38 ` Andrey Ryabinin
2015-10-06 18:11 ` Andy Lutomirski
2015-10-07 7:22 ` Ingo Molnar
2015-10-07 8:54 ` Andrey Ryabinin
2015-10-07 9:11 ` Andrey Ryabinin
2015-10-07 16:27 ` Andi Kleen
2015-10-07 18:48 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005163906.GE26924@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hpa@zytor.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wmglo@dent.med.uni-muenchen.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.