All of lore.kernel.org
 help / color / mirror / Atom feed
From: Remi Pommarel <repk@triplefau.lt>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Brandon Casey <drafnel@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3 1/1] Makefile: make curl-config path configurable
Date: Mon, 5 Oct 2015 23:05:45 +0200	[thread overview]
Message-ID: <20151005210545.GC386@cruxbox> (raw)
In-Reply-To: <20151005204909.GE11993@google.com>

On Mon, Oct 05, 2015 at 01:49:09PM -0700, Jonathan Nieder wrote:
> Remi Pommarel wrote:
> 
> > Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> 
> For what it's worth, with or without the tweaks below,
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

> 
> [...]
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -39,6 +39,10 @@ all::
> >  # Define CURLDIR=/foo/bar if your curl header and library files are in
> >  # /foo/bar/include and /foo/bar/lib directories.
> >  #
> > +# Define CURL_CONFIG to curl's configuration program that gives informations
> > +# about the library (ie curl's version, cflags, ...) . If not set it defaults
> > +# to 'curl-config'.
> 
> Extra spaces, some wording tweaks:
> 
> s/gives informations about the library/prints information about the library/
> s/(ie curl's version, cflags, .../) /(e.g., its version number)/
> s/If not set it defaults to/The default is/
> 

Do I need to resend a v4 patch with these modifications ? I am not sure
about the correct workflow here.

-- 
Rémi

  reply	other threads:[~2015-10-05 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 20:32 [PATCH v3 1/1] Makefile: make curl-config path configurable Remi Pommarel
2015-10-05 20:49 ` Jonathan Nieder
2015-10-05 21:05   ` Remi Pommarel [this message]
2015-10-05 21:11     ` Jonathan Nieder
2015-10-05 21:19       ` Remi Pommarel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005210545.GC386@cruxbox \
    --to=repk@triplefau.lt \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.