All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs
Date: Mon, 5 Oct 2015 23:24:33 +0300	[thread overview]
Message-ID: <20151005232244-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1444034124-28747-1-git-send-email-bharata@linux.vnet.ibm.com>

On Mon, Oct 05, 2015 at 02:05:22PM +0530, Bharata B Rao wrote:
> The suggested way to work around the virtio bug reported here
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html
> 
> is to introduce gaps between DIMMs. Igor's patchset changes the pc-dimm
> auto-address assignment to introduce gaps and ues the same from pc memhp.
> This patchset does the same for sPAPR PowerPC.
> 
> Before introducing the gap, ensure that memory hotplug region has enough
> room for alignment adjustment. We accommodate a max alignment of 256MB for
> each slot since sPAPR memory hotplug enforces an alignment requirement of
> 256MB on RAM size, maxmem and NUMA node mem sizes.
> 
> This applies on David's spapr-next branch + Igor's patchset applied.
> 
> This has been very lightly tested and intention is to get feedback
> on the correctness aspect of this.
> 
> Bharata B Rao (2):
>   spapr: Accommadate alignment gaps in hotplug memory region
>   spapr: Force gaps between DIMM's GPA

PC needs this, PPC needs this ... I don't see why would this not
apply everywhere. Isn't it time we just converted everyone?
Drop the gap flag, set it unconditionally for new machine types.

Thoughts?


>  hw/ppc/spapr.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> -- 
> 2.1.0
> 

  parent reply	other threads:[~2015-10-05 20:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05  8:35 [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs Bharata B Rao
2015-10-05  8:35 ` [Qemu-devel] [RFC v0 1/2] spapr: Accommadate alignment gaps in hotplug memory region Bharata B Rao
2015-10-05  9:05   ` Igor Mammedov
2015-10-06  3:29     ` David Gibson
2015-10-06  8:02       ` Igor Mammedov
2015-10-05 15:24   ` Thomas Huth
2015-10-05  8:35 ` [Qemu-devel] [RFC v0 2/2] spapr: Force gaps between DIMM's GPA Bharata B Rao
2015-10-05 20:24 ` Michael S. Tsirkin [this message]
2015-10-06  8:08   ` [Qemu-devel] [RFC v0 0/2] Enforce gaps between DIMMs Igor Mammedov
2015-10-06  9:33     ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005232244-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.