From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: "Marc Marí" <markmb@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads
Date: Tue, 6 Oct 2015 09:04:43 +0100 [thread overview]
Message-ID: <20151006080443.GC18212@stefanha-thinkpad> (raw)
In-Reply-To: <1444089115-28710-1-git-send-email-kevin@koconnor.net>
On Mon, Oct 05, 2015 at 07:51:55PM -0400, Kevin O'Connor wrote:
> +static uint64_t fw_cfg_dma_mem_read(void *opaque, hwaddr addr,
> + unsigned size)
> +{
> + // Return a signature value (and handle various read sizes)
> + return extract64(FW_CFG_DMA_SIGNATURE, (8 - addr - size) * 8, size*8);
Perhaps the maintainer can s/size*8/size * 8/ when applying this patch.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
prev parent reply other threads:[~2015-10-06 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 23:51 [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads Kevin O'Connor
2015-10-06 7:30 ` Laszlo Ersek
2015-10-06 14:29 ` Kevin O'Connor
2015-10-06 15:04 ` Laszlo Ersek
2015-10-08 9:55 ` Marc Marí
2015-10-06 8:04 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006080443.GC18212@stefanha-thinkpad \
--to=stefanha@gmail.com \
--cc=kevin@koconnor.net \
--cc=lersek@redhat.com \
--cc=markmb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.