From: Tony Lindgren <tony@atomide.com>
To: Luis de Bethencourt <luis@debethencourt.com>
Cc: linux-kernel@vger.kernel.org,
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver
Date: Tue, 6 Oct 2015 01:09:36 -0700 [thread overview]
Message-ID: <20151006080935.GK23801@atomide.com> (raw)
In-Reply-To: <20150917215025.GA8079@goodgumbo.baconseed.org>
* Luis de Bethencourt <luis@debethencourt.com> [150917 14:54]:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Looks OK to me, this would be mostly for n8x0:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mmc/host/omap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index b763b11..b9958a1 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1490,6 +1490,7 @@ static const struct of_device_id mmc_omap_match[] = {
> { .compatible = "ti,omap2420-mmc", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, mmc_omap_match);
> #endif
>
> static struct platform_driver mmc_omap_driver = {
> --
> 2.4.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2015-10-06 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 21:50 [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver Luis de Bethencourt
2015-10-06 8:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006080935.GK23801@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.