From: Christoph Hellwig <hch@infradead.org>
To: Lee Duncan <lduncan@suse.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Tejun Heo <tj@kernel.org>, Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management
Date: Tue, 6 Oct 2015 02:40:40 -0700 [thread overview]
Message-ID: <20151006094040.GA24624@infradead.org> (raw)
In-Reply-To: <1a69690d615610c1dee725db7e6d81cf2db28266.1444085255.git.lduncan@suse.com>
> struct Scsi_Host *scsi_host_lookup(unsigned short hostnum)
> {
> - struct device *cdev;
> - struct Scsi_Host *shost = NULL;
> -
> - cdev = class_find_device(&shost_class, NULL, &hostnum,
> - __scsi_host_match);
> - if (cdev) {
> - shost = scsi_host_get(class_to_shost(cdev));
> - put_device(cdev);
> - }
> + struct Scsi_Host *shost;
> +
> + spin_lock(&host_index_lock);
> + shost = idr_find(&host_index_idr, hostnum);
> + spin_unlock(&host_index_lock);
> +
> return shost;
How does this actually grab a reference to the host?
next prev parent reply other threads:[~2015-10-06 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 23:01 [PATCHv2 0/1] Update SCSI hosts to use idr for host number mgmt Lee Duncan
2015-10-05 23:01 ` [PATCHv2 1/1] SCSI: update hosts module to use idr index management Lee Duncan
2015-10-06 9:40 ` Christoph Hellwig [this message]
2015-10-06 17:14 ` Lee Duncan
2015-10-06 17:17 ` James Bottomley
2015-10-07 20:23 ` Hannes Reinecke
2015-10-07 23:39 ` James Bottomley
2015-10-06 13:00 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006094040.GA24624@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.com \
--cc=jthumshirn@suse.de \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.