From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbbJFJnk (ORCPT ); Tue, 6 Oct 2015 05:43:40 -0400 Received: from verein.lst.de ([213.95.11.211]:57426 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbbJFJni (ORCPT ); Tue, 6 Oct 2015 05:43:38 -0400 Date: Tue, 6 Oct 2015 11:43:36 +0200 From: Christoph Hellwig To: Akinobu Mita Cc: Christoph Hellwig , LKML , Jens Axboe , Ming Lei Subject: Re: [PATCH v4 3/7] blk-mq: Fix use after of free q->mq_map Message-ID: <20151006094336.GA29336@lst.de> References: <1443287365-4244-1-git-send-email-akinobu.mita@gmail.com> <1443287365-4244-4-git-send-email-akinobu.mita@gmail.com> <20150929065235.GB14911@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2015 at 08:50:47AM +0900, Akinobu Mita wrote: > 2015-09-29 15:52 GMT+09:00 Christoph Hellwig : > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > Can you also add a patch that renames blk_mq_free_queue to > > blk_mq_cleaup_queue and adds a comment that we should not free any memory > > here? We had way too many bugs of this kinds unfortunately. > > Renaming blk_mq_free_queue to blk_mq_cleaup_queue sounds good because > it is called from blk_cleanup_queue(). > > How about adding comment like below? This looks great. It's a lot more than what I though but it looks correct and useful!