From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler
Date: Tue, 6 Oct 2015 11:13:27 +0200 [thread overview]
Message-ID: <20151006111327.2bd7fedd@bahia.local> (raw)
In-Reply-To: <20151006080914.GB19089@stefanha-thinkpad>
On Tue, 6 Oct 2015 09:09:14 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote:
> > If the user tries to hot unplug a virtio-9p device, it seems to succeed but
> > in fact:
> > - virtio-9p coroutines thread pool and async queue are leaked
> > - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate
> >
> > This patch brings hot unplug support to virtio-9p-device. It fixes both
> > above issues.
> >
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > ---
> > hw/9pfs/virtio-9p-device.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> What happens to in-flight I/O requests? We cannot assume that the guest
> driver quiesces the device.
>
We can assume that the guest has unmounted the 9p share otherwise migration
is blocked... is it possible we still have in-flight I/O requests in this
scenario ?
next prev parent reply other threads:[~2015-10-06 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 9:07 [Qemu-devel] [PATCH 0/3] virtio-9p: hotplug and migration support Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 1/3] virtio-9p-coth: add release function and fix init error path Greg Kurz
2015-10-06 9:16 ` Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler Greg Kurz
2015-10-06 8:09 ` Stefan Hajnoczi
2015-10-06 9:13 ` Greg Kurz [this message]
2015-10-07 8:50 ` Aneesh Kumar K.V
2015-10-09 7:23 ` Greg Kurz
2015-10-09 7:36 ` Michael S. Tsirkin
2015-10-09 10:54 ` Greg Kurz
2015-10-05 9:07 ` [Qemu-devel] [PATCH 3/3] virtio-9p: add savem handlers Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006111327.2bd7fedd@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.