From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os Date: Tue, 6 Oct 2015 15:04:28 +0200 Message-ID: <20151006130428.GW3383@phenom.ffwll.local> References: <1444058564-13663-1-git-send-email-shobhit.kumar@intel.com> <1444059355.31325.67.camel@intel.com> <56139AD9.4020205@linux.intel.com> <1444128109.8306.10.camel@intel.com> <5613AA8F.6080006@linux.intel.com> <20151006111952.GI3383@phenom.ffwll.local> <20151006114144.GU26517@intel.com> <20151006121920.GP3383@phenom.ffwll.local> <5613C208.8050801@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id A15CE6E135 for ; Tue, 6 Oct 2015 06:01:35 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so165164083wic.1 for ; Tue, 06 Oct 2015 06:01:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5613C208.8050801@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Kumar, Shobhit" Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMDYsIDIwMTUgYXQgMDY6MTM6NTJQTSArMDUzMCwgS3VtYXIsIFNob2JoaXQg d3JvdGU6Cj4gT24gMTAvMDYvMjAxNSAwNTo0OSBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ T24gVHVlLCBPY3QgMDYsIDIwMTUgYXQgMDI6NDE6NDRQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+ID4+T24gVHVlLCBPY3QgMDYsIDIwMTUgYXQgMDE6MTk6NTJQTSArMDIwMCwgRGFu aWVsIFZldHRlciB3cm90ZToKPiA+Pj5PbiBUdWUsIE9jdCAwNiwgMjAxNSBhdCAwNDozMzo0M1BN ICswNTMwLCBLdW1hciwgU2hvYmhpdCB3cm90ZToKPiA+Pj4+T24gMTAvMDYvMjAxNSAwNDoxMSBQ TSwgSW1yZSBEZWFrIHdyb3RlOgo+ID4+Pj4+T24gdGksIDIwMTUtMTAtMDYgYXQgMTU6MjYgKzA1 MzAsIEt1bWFyLCBTaG9iaGl0IHdyb3RlOgo+ID4+Pj4+Pk9uIDEwLzA1LzIwMTUgMDk6MDUgUE0s IEltcmUgRGVhayB3cm90ZToKPiA+Pj4+Pj4+T24gbWEsIDIwMTUtMTAtMDUgYXQgMjA6NTIgKzA1 MzAsIFNob2JoaXQgS3VtYXIgd3JvdGU6Cj4gPj4+Pj4+Pj5Nb3N0bHkgcmV1c2Ugd2hhdCBpcyBw cm9ncmFtbWVkIGJ5IHByZS1vcywgYnV0IGluIGNhc2UgdGhlcmUgaXMgbm8KPiA+Pj4+Pj4+PnBy ZS1vcyBpbml0aWFsaXphdGlvbiwgaW5pdCB0aGUgY2RjbGsgd2l0aCB0aGUgZGVmYXVsdCB2YWx1 ZS4KPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+Q2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNv bT4KPiA+Pj4+Pj4+PlNpZ25lZC1vZmYtYnk6IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJA aW50ZWwuY29tPgo+ID4+Pj4+Pj4+LS0tCj4gPj4+Pj4+Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kZGkuYyB8IDYgKystLS0tCj4gPj4+Pj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj5kaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+ID4+Pj4+Pj4+aW5kZXggMmQzY2M4Mi4uNjc1YzYwZCAxMDA2NDQK PiA+Pj4+Pj4+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPj4+Pj4+ Pj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4+Pj4+Pj4+QEAgLTI5 NDcsMTAgKzI5NDcsOCBAQCB2b2lkIGludGVsX2RkaV9wbGxfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gICAJCWNkY2xrX2ZyZXEgPSBkZXZfcHJpdi0+ ZGlzcGxheS5nZXRfZGlzcGxheV9jbG9ja19zcGVlZChkZXYpOwo+ID4+Pj4+Pj4+ICAgCQlkZXZf cHJpdi0+c2tsX2Jvb3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+ID4+Pj4+Pj4+LQkJaWYgKCEoSTkx NV9SRUFEKExDUExMMV9DVEwpICYgTENQTExfUExMX0VOQUJMRSkpCj4gPj4+Pj4+Pj4tCQkJRFJN X0VSUk9SKCJMQ1BMTDEgaXMgZGlzYWJsZWRcbiIpOwo+ID4+Pj4+Pj4+LQkJZWxzZQo+ID4+Pj4+ Pj4+LQkJCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRldl9wcml2LCBQT1dFUl9ET01BSU5fUExM Uyk7Cj4gPj4+Pj4+Pj4rCj4gPj4+Pj4+Pj4rCQlza2xfaW5pdF9jZGNsayhkZXZfcHJpdik7Cj4g Pj4+Pj4+Pgo+ID4+Pj4+Pj5Ib3cgZG9lcyB0aGlzIHByZXZlbnQgY2hhbmdpbmcgdGhlIGNsb2Nr IGlmIEJJT1MgZGlkIGVuYWJsZSBzb21lIG91dHB1dD8KPiA+Pj4+Pj4+V2Ugc2hvdWxkbid0IGNo YW5nZSB0aGUgY2xvY2sgaW4gdGhhdCBjYXNlLgo+ID4+Pj4+Pgo+ID4+Pj4+PkluIHRoYXQgY2Fz ZSBpdCB3aWxsIHRyeSB0byByZS1hcHBseSB0aGUgc2FtZSBjbG9jayB0aGF0IEJJT1MgZW5hYmxl ZC4KPiA+Pj4+Pj5Ob3Qgc3VyZSBpZiB0aGlzIGlzIGFsbG93ZWQsIGJ1dCBJIGNoZWNrZWQgdGhl IGNkY2xvY2sgY2hhbmdlIHNlcXVlbmNlCj4gPj4+Pj4+YW5kIGl0IGlzIG1vc3RseSBmb2xsb3dl ZCBpbiBza2xfaW5pdF9jZGNsay4KPiA+Pj4+Pj5JbiBteSB0ZXN0cyB3aGVyZSBCSU9TIGRvZXMg ZW5hYmxlIHRoaXMsIEkgZmFjZWQgbm8gaXNzdWVzIGluCj4gPj4+Pj4+aW5pdGlhbGl6aW5nIGFn YWluIGluIGRyaXZlci4KPiA+Pj4+Pgo+ID4+Pj4+VGhlIGZpcnN0IHN0ZXAgaW4gdGhhdCBzZXF1 ZW5jZToKPiA+Pj4+PiJEaXNhYmxlIGFsbCBkaXNwbGF5IGVuZ2luZSBmdW5jdGlvbnMgdXNpbmcg dGhlIGZ1bGwgbW9kZSBzZXQgZGlzYWJsZQo+ID4+Pj4+c2VxdWVuY2Ugb24gYWxsIHBpcGVzLCBw b3J0cywgYW5kIHBsYW5lcy4iCj4gPj4+Pgo+ID4+Pj5PaCwgeWVhaCwgSSBhZ2FpbiBtYWRlIG1p c3Rha2Ugb2YgYXNzdW1pbmcgdGhhdCBkaXNwbGF5IGlzIG5vdCBlbmFibGVkIGluCj4gPj4+PnRo ZSBmaXJzdCBwbGFjZS4gWW91IGFyZSByaWdodCwgdGhvdWdoIGl0IHdvcmtzIGlmIEkgY2hhbmdl IHRoZSBjbG9jayBhZ2Fpbi4KPiA+Pj4+Cj4gPj4+Pj4KPiA+Pj4+PlNvIHRoZSBwcm9ibGVtIGlz IG5vdCB0aGF0IHRoZSBQTEwgaXRzZWxmIG1heSBiZSBlbmFibGVkIGhlcmUgKGFzIEJJT1MKPiA+ Pj4+PmxlZnQgaXQpLCBidXQgdGhhdCBzb21lIG91dHB1dCBpcyBhbHNvIGVuYWJsZWQuCj4gPj4+ Pgo+ID4+Pj5ZZXMuCj4gPj4+Pgo+ID4+Pj4+Cj4gPj4+Pj4+SSBoYXZlIG5vdGljZWQgb24gc29t ZSBwcmUtb3MgdGhpcyB2YWx1ZSBpcyBwcm9ncmFtbWVkIGNvcnJlY3RseSBleGNlcHQKPiA+Pj4+ Pj5mb3IgdGhlIGRlY2ltYWwgcGFydC4gVGhhdCBjYXVzZXMgQVVYIHRyYW5zYWN0aW9ucyB0byBm YWlsIG9uIFNLbC4gVGhhdAo+ID4+Pj4+PmlzIHdoYXQgdHJpZ2dlcmVkIHRoaXMgcGF0Y2ggYWN0 dWFsbHkuIFNvIG90aGVyIHdheSBpcyB0byBjb21wbGV0ZWx5Cj4gPj4+Pj4+dmFsaWRhdGUgdGhl IHZhbHVlIGluIGdldF9kaXNwbGF5X2Nsb2NrX3NwZWVkIGluc3RlYWQgb2YgYml0WzI4OjI2XSBh bmQKPiA+Pj4+Pj50aGVuIGlmIHdyb25nIHRoZW4gb25seSBkbyB0aGUgY2RjbGsgaW5pdC4KPiA+ Pj4+Pgo+ID4+Pj4+SSB0aGluayB3ZSdkIG5lZWQgdG8gZGV0ZWN0IGF0IHRoaXMgcG9pbnQgaWYg b3V0cHV0cyBhcmUgZW5hYmxlZCBhbmQKPiA+Pj4+Pm9ubHkgYXR0ZW1wdCB0byB3b3JrIGFyb3Vu ZCB0aGUgYWJvdmUgQklPUyBwcm9ibGVtIGlmIHRoaXMgaXMgbm90IHRoZQo+ID4+Pj4+Y2FzZS4g QWx0ZXJuYXRpdmVseSB5b3UgY291bGQgYWxzbyBkaXNhYmxlIHRoZSBhY3RpdmUgb3V0cHV0cyBh cyBhIGZpcnN0Cj4gPj4+Pj5zdGVwLgo+ID4+Pj4KPiA+Pj4+T2ssIGxldCBtZSBkZXRlY3QgaWYg YW55IG91dHB1dCBpcyBlbmFibGVkIGJ5IEJJT1MgYW5kIGFjY29yZGluZ2x5Cj4gPj4+PmluaXRp YWxpemUgY2RjbGsuCj4gPj4+Cj4gPj4+VGhlc2Uga2luZCBvZiBmaXhpdXBzIHNob3VsZCBiZSBk b25lIGFmdGVyIHRoZSBodyBzdGF0ZSByZWFkb3V0LiBXZQo+ID4+PmFscmVhZHkgaGF2ZSBzYW5p dGl6ZV9jcnRjL3BsbC9lbmNvZGVyIGZ1bmN0aW9ucywgcHJvYmFibHkgYmVzdCBpZiB3ZSBhZGQK PiA+Pj5hIHNhbml0aXplX2NkY2xrIG9yIHNpbWlsYXIgZm9yIHRoaXMgYXQgdGhlIHZlcnkgZW5k IG9mIHRoZSBodyBzdGF0ZQo+ID4+PnNhbml0aXplIHNlcXVlbmNlLgo+ID4+Cj4gPj5DYW4ndCBi ZSBkb25lIGlmIHdlIGFscmVhZHkgbmVlZCBhIHNvbWV3aGF0IHNhbmUgY2RjbGsgZm9yIHRoZQo+ ID4+ZURQIEFVWCBwcm9iaW5nIGFuZCB3aGF0bm90Lgo+ID4+Cj4gPj5Gb3IgYWN0dWFsbHkgZW5h YmxpbmcgdGhlIGNkY2xrIGZvciBwdXNoaW5nIHBpeGVscywgd2Ugd291bGRuJ3QgbmVlZAo+ID4+ dG8gZG8gYW55dGhpbmcgZXhjZXB0IGFjdHVhbGx5IHBsdWcgaWEgYSBjYWxjX2NkY2xrIGZvciBT S0wuIE5vIGlkZWEKPiA+PndoeSB3ZSdyZSBub3QgZG9pbmcgdGhhdCBjdXJyZW50bHkuIFNvbWUg ZXh0cmEgY2FyZSBtYXkgYmUgbmVlZGVkCj4gPj5kdWUgdG8gdGhlIGVEUCBEUExMMCB1c2FnIElJ UkMuCj4gPgo+ID5IbSByaWdodCwgY2RsY2sgaXMgaW4gdGhlIHRvcC1sZXZlbCBwb3dlciBkb21h aW4uIEFkZGVkIGZ1biBpcyB0aGF0IHdpdGgKPiA+ZG1jIHRoZSBmaXJtd2FyZSBpcyBzdXBwb3Nl ZCB0byBoYW5kbGUgaXQuIE1lc3N5IDooCj4gCj4gWWVzLCBleGFjdGx5LiBIb3cgYWJvdXQganVz dCBhZGRpbmcgdmVyaWZ5X2NkY2xrIGFuZCBjYWxsaW5nIGluCj4gZ2V0X2Rpc3BsYXlfY2xvY2tf c3BlZWQgdG8gY2hlY2sgaWYgY2RjbGsgaXMgcHJvZ3JhbW1lZCBjb3JyZWN0bHkgYWxvbmcgd2l0 aAo+IHJlbGF0ZWQgRFBMTDAgVkNPIHNldHRpbmdzIGZvciBub3cuIElmIGFsbCBsb29rcyBnb29k LCB0aGVuIHNraXAgZWxzZQo+IGluaXRpYWxpemUuIE5vdyBpbiB0aGF0IGNhc2UgaWYgd2UgaGF2 ZSB0byBpbml0aWFsaXplIHdoZXJlIGRvIHdlIGdldCB0aGUKPiBjZGNsb2NrIHRvIGluaXRpYWxp emUgd2l0aCBhdCB0aGlzIHBvaW50ID8gQW55IGRlZmF1bHQgaW4gVkJUID8gT3IgZ28gd2l0aAo+ IG1pbmltdW0gYnkgZGVmYXVsdCBhbmQgaXQgY2FuIGJlIGJ1bXBlZCB1cCBsYXRlciBpZiBuZWVk ZWQuCgpKdXN0IGluaXRpYWxpemUgdG8gdGhlIHNsb3dlc3QgcG9zc2libGUgdmFsdWUsIG9uY2Ug d2UgaGF2ZSBkeW5hbWljIGNkY2xrCnN3aXRjaGluZyBmb3Igc2tsLiBCdXQgdGhhdCBzZWVtcyB0 byBiZSBzdHVjayBiZWhpbmQgcmVzb2x2aW5nIHRoYXQgYmlnCmNvbmZ1c2lvbiBhcm91bmQgZG1j IGFuZCB0aGUgc2VxdWVuY2UgZm9yIHJ1bnRpbWUgcG0uIFdpdGhvdXQgZHluYW1pYwpjZGNsayB3 ZSBoYXZlIHRvIHBpY2sgdGhlIG1heGltdW0uCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29m dHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==