Re: [PATCH v3 1/2] btrfs: Fix lost-data-profile caused by auto removing bg

[Chris Mason <clm@fb.com>]

Hi,

On Sun, Oct 04, 2015 at 12:28:39AM +0800, Zhao Lei wrote:
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index 79a5bd9..c05b975 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -10010,8 +10010,18 @@ void btrfs_delete_unused_bgs(struct btrfs_fs_info *fs_info)
>  		block_group = list_first_entry(&fs_info->unused_bgs,
>  					       struct btrfs_block_group_cache,
>  					       bg_list);
> -		space_info = block_group->space_info;
>  		list_del_init(&block_group->bg_list);
> +
> +		space_info = block_group->space_info;
> +
> +		down_read(&space_info->groups_sem);

Thanks for reworking this, are there other patches that I'm missing that
are meant to go in before this one?

The down_read() this patch adds is inside a spinlock().

-chris