From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753063AbbJFQaM (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 12:30:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49426 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752276AbbJFQaK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 12:30:10 -0400
Date: Tue, 6 Oct 2015 18:26:54 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Rientjes <rientjes@google.com>, Kyle Walker <kwalker@redhat.com>,
        Michal Hocko <mhocko@kernel.org>,
        Stanislav Kozina <skozina@redhat.com>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] mm/oom_kill: change oom_kill_process() to bump
	->mm_count rather than ->mm_users
Message-ID: <20151006162654.GA9570@redhat.com>
References: <20151005163427.GA20595@redhat.com> <20151005173601.GA23150@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151005173601.GA23150@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05, Oleg Nesterov wrote:
>
> Self nack to the changelog ;)
>
> I still think the patch is fine, I'll resend it. But the changelog
> is wrong, in the case above access_process_vm() adds another reference
> to ->mm_users, so mmput() can never lead to mm_users == 0.

Please see v2 with updated changelog I am going to send. However, somehow
I forgot that "mm/oom_kill.c: fix potentially killing unrelated process"
still sits in -mm, so I guess it would be better to fold this change into
mmoom-fix-potentially-killing-unrelated-process.patch.

Oleg.