From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Input: db9 - store object at correct index
Date: Tue, 6 Oct 2015 15:35:50 -0700 [thread overview]
Message-ID: <20151006223550.GB31850@dtor-ws> (raw)
In-Reply-To: <20151006053859.GG4745@sudip-pc>
On Tue, Oct 06, 2015 at 11:08:59AM +0530, Sudip Mukherjee wrote:
> On Mon, Oct 05, 2015 at 05:32:05PM -0700, Dmitry Torokhov wrote:
> > On Sat, Oct 03, 2015 at 02:54:56PM +0530, Sudip Mukherjee wrote:
> > > The variable i is used to check the port to attach to and we are
> > > supposed to save the reference of struct db9 in the location given by
> > > db9_base[i]. But after finding out the index, i is getting modified again
> > > so we saved in a wrong index.
> > > While at it mark db9_base[i] as NULL after it is freed.
> > >
> > > Fixes: 2260c419b52b ("Input: db9 - use parallel port device model")
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >
> > Applied the lot, thank you.
>
> Thanks. And the change for serio/parkbd was pending. You said it was
> clashing with other changs. Do i need to rebase and send you?
No, I applied it now.
Thanks.
--
Dmitry
prev parent reply other threads:[~2015-10-06 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 9:24 [PATCH v2 1/3] Input: db9 - store object at correct index Sudip Mukherjee
2015-10-03 9:24 ` [PATCH v2 2/3] Input: gamecon " Sudip Mukherjee
2015-10-03 9:24 ` [PATCH v2 3/3] Input: turbografx - store object in " Sudip Mukherjee
2015-10-06 0:32 ` [PATCH v2 1/3] Input: db9 - store object at " Dmitry Torokhov
2015-10-06 5:38 ` Sudip Mukherjee
2015-10-06 22:35 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006223550.GB31850@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.