From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 92934E00B04; Wed, 7 Oct 2015 03:22:32 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [192.55.52.93 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0D4FEE00343 for ; Wed, 7 Oct 2015 03:22:30 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 07 Oct 2015 03:22:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,648,1437462000"; d="scan'208";a="821201087" Received: from linux.intel.com ([10.23.219.25]) by orsmga002.jf.intel.com with ESMTP; 07 Oct 2015 03:22:30 -0700 Received: from linux.intel.com (vmed.fi.intel.com [10.237.72.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTP id DDF056A4083; Wed, 7 Oct 2015 03:21:32 -0700 (PDT) Date: Wed, 7 Oct 2015 13:22:25 +0300 From: Ed Bartosh To: Elliot Smith Message-ID: <20151007102225.GA7059@linux.intel.com> References: <1444052375-17256-1-git-send-email-elliot.smith@intel.com> MIME-Version: 1.0 In-Reply-To: <1444052375-17256-1-git-send-email-elliot.smith@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Cc: toaster@yoctoproject.org Subject: Re: [review-request][PATCH 0/2][v2] Fix cooker log download button X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: ed.bartosh@linux.intel.com List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 10:22:32 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sent to upstream. Pushed to toaster-next. On Mon, Oct 05, 2015 at 02:39:33PM +0100, Elliot Smith wrote: > This supersedes https://lists.yoctoproject.org/pipermail/toaster/2015-September/002877.html > (which was a single commit). > > * Retrieve a build's log file location directly from the file system, > as the one which is available at the time of the BuildStarted event > is incorrect. > > * Hide the "Download build log" button for builds which fail early > (e.g. due to recipe parsing) and consequently have no cooker_log_path. > > Changes since 986f6b04b26bba9d01393f8f4ced4e0f4385368a (toaster-next) are in > git://git.yoctoproject.org/poky-contrib, elliot/toaster/wrong_log-8373 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/wrong_log-8373 > > Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8373 > > Elliot Smith (2): > toaster: Manually retrieve log file location from filesystem > toaster: Hide "Download build log" button if log doesn't exist > > bitbake/lib/bb/ui/toasterui.py | 31 +++++++++++++++++++++- > .../toastergui/templates/builddashboard.html | 4 ++- > 2 files changed, 33 insertions(+), 2 deletions(-) > > -- > Elliot Smith > Software Engineer > Intel OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster -- -- Regards, Ed