From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility Date: Wed, 7 Oct 2015 03:41:19 -0700 Message-ID: <20151007102822.GT23801@atomide.com> References: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de> <1444162070-22034-2-git-send-email-u.kleine-koenig@pengutronix.de> <5614CDAE.6070604@ti.com> <20151007075338.GH3982@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20151007075338.GH3982@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Roger Quadros List-Id: linux-omap@vger.kernel.org KiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiBbMTUx MDA3IDAwOjU3XToKPiBPbiBXZWQsIE9jdCAwNywgMjAxNSBhdCAxMDo0NTo1MEFNICswMzAwLCBS b2dlciBRdWFkcm9zIHdyb3RlOgo+ID4gCj4gPiBIb3cgYWJvdXQgdGhpcyBpbnN0ZWFkPwo+ID4g Cj4gPiBOT1RFOiBBcGFydCBmcm9tIG1hdGNoaW5nIHRoZSByZWdpc3RlciBzZXR1cCB3aXRoIHRo ZSBib290bG9hZGVyIHlvdSBhbHNvIG5lZWQgdG8KPiA+IG1hdGNoIHRoZSBHUE1DIEZDTEsgZnJl cXVlbmN5IHVzZWQgYnkgdGhlIGJvb3Rsb2FkZXIgZWxzZSB0aGUgR1BNQyB0aW1pbmdzCj4gPiB3 b24ndCBiZSBpZGVudGljYWwgd2l0aCB0aGUgYm9vdGxvYWRlciB0aW1pbmdzLgo+IFllYWgsIHNv dW5kcyBiZXR0ZXIsIHRoYW5rcy4KPiAKPiA+IEFsc28geW91IG1pZ2h0IG5lZWQgdG8gYnVpbGQg dGhpcyBwYXRjaCBvbiB0b3Agb2YKPiA+IGh0dHA6Ly9hcnRpY2xlLmdtYW5lLm9yZy9nbWFuZS5s aW51eC5rZXJuZWwvMjA1NDc5Ngo+IEkgdGFsa2VkIHRvIFRvbnkgYWJvdXQgdGhpcyBwYXRjaCB5 ZXN0ZXJkYXkgb24gaXJjLCBidXQgSSBkaWRuJ3QgZmluZCBpdAo+IGluIHRoZSBhcmNoaXZlcyB5 ZXQgd2hlbiBJIHNlbnQgbXkgbWFpbC4KClllcyBzb3JyeSBoZXJlJ3MgYSByZXBvc3Qgd2l0aCB5 b3VyIGFuZCBSb2dlcidzIGNoYW5nZXMgZm9sZGVkIGluIGFuZAplZGl0ZWQgYSBiaXQuIFByb2Jh Ymx5IGJlc3QgdG8ga2VlcCB0aGVtIHRvZ2V0aGVyIHdpdGggdGhpcyBwYXRjaC4KCkRvZXMgdGhl IGZvbGxvd2luZyBsb29rIE9LIHRvIHlvdSBndXlzPwoKUmVnYXJkcywKClRvbnkKCjg8IC0tLS0t LS0tLS0tLS0tLS0KRnJvbTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4KRGF0ZTog VHVlLCA2IE9jdCAyMDE1IDA1OjM2OjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gbWVtb3J5OiBv bWFwLWdwbWM6IEZpeCB1bnNlbGVjdGFibGUgZGVidWcgb3B0aW9uIGZvciBHUE1DCk1JTUUtVmVy c2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50 LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgpDb21taXQgNjNhYTk0NWIxMDEzICgibWVtb3J5OiBv bWFwLWdwbWM6IEFkZCBLY29uZmlnIG9wdGlvbiBmb3IgZGVidWciKQphZGRlZCBhIGRlYnVnIG9w dGlvbiBmb3IgR1BNQywgYnV0IHNvbWVob3cgbWFuYWdlZCB0byBrZWVwIGl0IHVuc2VsZWN0YWJs ZS4KClRoaXMgcHJvYmFibHkgaGFwcGVuZWQgYmVjYXVzZSBJIGhhZCBzb21lIHVuY29tbWl0dGVk IGNoYW5nZXMgYW5kIHRoZQpHUE1DIG9wdGlvbiBpcyBzZWxlY3RlZCBpbiB0aGUgcGxhdGZvcm0g c3BlY2lmaWMgS2NvbmZpZy4KCkxldCdzIGFsc28gdXBkYXRlIHRoZSBkZXNjcmlwdGlvbiBhIGJp dCwgaXQgZG9lcyBub3QgbWVudGlvbiB0aGF0CmVuYWJsaW5nIHRoZSBkZWJ1ZyBvcHRpb24gYWxz byBkaXNhYmxlcyB0aGUgcmVzZXQgb2YgR1BNQyBjb250cm9sbGVyCmR1cmluZyB0aGUgaW5pdCBh cyBwb2ludGVkIG91dCBieSBVd2UgS2xlaW5lLUvDtm5pZwo8dS5rbGVpbmUta29lbmlnQHBlbmd1 dHJvbml4LmRlPiBhbmQgUm9nZXIgUXVhZHJvcyA8cm9nZXJxQHRpLmNvbT4uCgpGaXhlczogNjNh YTk0NWIxMDEzICgibWVtb3J5OiBvbWFwLWdwbWM6IEFkZCBLY29uZmlnIG9wdGlvbiBmb3IgZGVi dWciKQpSZXBvcnRlZC1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5n dXRyb25peC5kZT4KU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNv bT4KCi0tLSBhL2RyaXZlcnMvbWVtb3J5L0tjb25maWcKKysrIGIvZHJpdmVycy9tZW1vcnkvS2Nv bmZpZwpAQCAtNTgsMTIgKzU4LDE4IEBAIGNvbmZpZyBPTUFQX0dQTUMKIAkgIG1lbW9yeSBkcml2 ZXMgbGlrZSBOT1IsIE5BTkQsIE9uZU5BTkQsIFNSQU0uCiAKIGNvbmZpZyBPTUFQX0dQTUNfREVC VUcKLQlib29sCisJYm9vbCAiRW5hYmxlIEdQTUMgZGVidWcgb3V0cHV0IGFuZCBza2lwIHJlc2V0 IG9mIEdQTUMgZHVyaW5nIGluaXQiCiAJZGVwZW5kcyBvbiBPTUFQX0dQTUMKIAloZWxwCiAJICBF bmFibGVzIHZlcmJvc2UgZGVidWdnaW5nIG1vc3RseSB0byBkZWNvZGUgdGhlIGJvb3Rsb2FkZXIg cHJvdmlkZWQKLQkgIHRpbWluZ3MuIEVuYWJsZSB0aGlzIGR1cmluZyBkZXZlbG9wbWVudCB0byBj b25maWd1cmUgZGV2aWNlcwotCSAgY29ubmVjdGVkIHRvIHRoZSBHUE1DIGJ1cy4KKwkgIHRpbWlu Z3MuIFRvIHByZXNlcnZlIHRoZSBib290bG9hZGVyIHByb3ZpZGVkIHRpbWluZ3MsIHRoZSByZXNl dAorCSAgb2YgR1BNQyBpcyBza2lwcGVkIGR1cmluZyBpbml0LiBFbmFibGUgdGhpcyBkdXJpbmcg ZGV2ZWxvcG1lbnQgdG8KKwkgIGNvbmZpZ3VyZSBkZXZpY2VzIGNvbm5lY3RlZCB0byB0aGUgR1BN QyBidXMuCisKKwkgIE5PVEU6IEluIGFkZGl0aW9uIHRvIG1hdGNoaW5nIHRoZSByZWdpc3RlciBz ZXR1cCB3aXRoIHRoZSBib290bG9hZGVyCisJICB5b3UgYWxzbyBuZWVkIHRvIG1hdGNoIHRoZSBH UE1DIEZDTEsgZnJlcXVlbmN5IHVzZWQgYnkgdGhlCisJICBib290bG9hZGVyIG9yIGVsc2UgdGhl IEdQTUMgdGltaW5ncyB3b24ndCBiZSBpZGVudGljYWwgd2l0aCB0aGUKKwkgIGJvb3Rsb2FkZXIg dGltaW5ncy4KIAogY29uZmlnIE1WRUJVX0RFVkJVUwogCWJvb2wgIk1hcnZlbGwgRUJVIERldmlj ZSBCdXMgQ29udHJvbGxlciIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 7 Oct 2015 03:41:19 -0700 Subject: [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility In-Reply-To: <20151007075338.GH3982@pengutronix.de> References: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de> <1444162070-22034-2-git-send-email-u.kleine-koenig@pengutronix.de> <5614CDAE.6070604@ti.com> <20151007075338.GH3982@pengutronix.de> Message-ID: <20151007102822.GT23801@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Uwe Kleine-K?nig [151007 00:57]: > On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: > > > > How about this instead? > > > > NOTE: Apart from matching the register setup with the bootloader you also need to > > match the GPMC FCLK frequency used by the bootloader else the GPMC timings > > won't be identical with the bootloader timings. > Yeah, sounds better, thanks. > > > Also you might need to build this patch on top of > > http://article.gmane.org/gmane.linux.kernel/2054796 > I talked to Tony about this patch yesterday on irc, but I didn't find it > in the archives yet when I sent my mail. Yes sorry here's a repost with your and Roger's changes folded in and edited a bit. Probably best to keep them together with this patch. Does the following look OK to you guys? Regards, Tony 8< ---------------- From: Tony Lindgren Date: Tue, 6 Oct 2015 05:36:17 -0700 Subject: [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") added a debug option for GPMC, but somehow managed to keep it unselectable. This probably happened because I had some uncommitted changes and the GPMC option is selected in the platform specific Kconfig. Let's also update the description a bit, it does not mention that enabling the debug option also disables the reset of GPMC controller during the init as pointed out by Uwe Kleine-K?nig and Roger Quadros . Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") Reported-by: Uwe Kleine-K?nig Signed-off-by: Tony Lindgren --- a/drivers/memory/Kconfig +++ b/drivers/memory/Kconfig @@ -58,12 +58,18 @@ config OMAP_GPMC memory drives like NOR, NAND, OneNAND, SRAM. config OMAP_GPMC_DEBUG - bool + bool "Enable GPMC debug output and skip reset of GPMC during init" depends on OMAP_GPMC help Enables verbose debugging mostly to decode the bootloader provided - timings. Enable this during development to configure devices - connected to the GPMC bus. + timings. To preserve the bootloader provided timings, the reset + of GPMC is skipped during init. Enable this during development to + configure devices connected to the GPMC bus. + + NOTE: In addition to matching the register setup with the bootloader + you also need to match the GPMC FCLK frequency used by the + bootloader or else the GPMC timings won't be identical with the + bootloader timings. config MVEBU_DEVBUS bool "Marvell EBU Device Bus Controller"