Re: [Outreachy kernel] [PATCH] Staging: most: video: Changed the return value integer to NULL

[Shivani Bhardwaj <shivanib134@gmail.com>]

On Wed, Oct 07, 2015 at 12:33:32PM +0100, Julia Lawall wrote:
> 
> 
> On Wed, 7 Oct 2015, Shivani Bhardwaj wrote:
> 
> > On Wed, Oct 07, 2015 at 12:15:11PM +0100, Julia Lawall wrote:
> > > On Wed, 7 Oct 2015, Shivani Bhardwaj wrote:
> > >
> > > > Fixed the sparse warning : Using plain integer as NULL pointer, by
> > > > changing the return value of function *get_aim_dev(struct, int) from 0
> > > > to NULL.
> > >
> > > If you want, you could try doing this sort of thing with Coccinelle.  An
> > > easy case is the assignment case.  The following would find an assignment
> > > where the type is a pointer and the value is 0:
> > >
> > > @@
> > > type T;
> > > T *x;
> > > @@
> > >
> > > x =
> > > - 0
> > > + NULL
> > >
> > > This makes a rule where T is an arbitrary type and x is an expression that
> > > has type pointer to type T.  Then it searches for an assignment where
> > > there is this pointer typed expression on the left side and 0 on the right
> > > side, and then makes the change.
> > >
> > > The function return case is a bit more complicated, because you have to
> > > find the function return type and the return statement, which are not
> > > right next to each other.  But it can be done as well.
> > >
> > > You can find out more at the Coccinelle web site: coccinelle.lip6.fr.
> > > There are some tutorials at the papers and slides link.
> > >
> > > julia
> > >
> > Thanks, Julia! Is this patch not acceptable?
> 
> The patch looks fine :)  It was just something else to try.
> 
> julia
>
OK. Thank you, Julia! :)
> > > >
> > > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > > > ---
> > > >  drivers/staging/most/aim-v4l2/video.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c
> > > > index d968791..8333245 100644
> > > > --- a/drivers/staging/most/aim-v4l2/video.c
> > > > +++ b/drivers/staging/most/aim-v4l2/video.c
> > > > @@ -430,7 +430,7 @@ static struct most_video_dev *get_aim_dev(
> > > >  		}
> > > >  	}
> > > >  	spin_unlock(&list_lock);
> > > > -	return 0;
> > > > +	return NULL;
> > > >  }
> > > >
> > > >  static int aim_rx_data(struct mbo *mbo)
> > > > --
> > > > 2.1.0
> > > >
> > > > --
> > > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007101433.GA50144%40ubuntu.
> > > > For more options, visit https://groups.google.com/d/optout.
> > > >
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007113026.GA51614%40ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >