From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Wed, 7 Oct 2015 13:56:31 +0100 Subject: [PATCH v2 3/3] nvmem: core: add sysfs file mode flag in nvmem_config In-Reply-To: <1444215664-10921-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1444215536-10783-1-git-send-email-srinivas.kandagatla@linaro.org> <1444215664-10921-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <20151007125631.GC7962@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 07, 2015 at 12:01:04PM +0100, Srinivas Kandagatla wrote: > This patch adds mode variable to nvmem_config structure which will allow > providers to specify the permissions for the sysfs binary file. > This mode is applied on top of root-only access permissions set by > the core. > > Having this flag would give more flexibility to providers to decide > which permissions to set on the sysfs binary file entry. And they will get it wrong, please don't do this. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753205AbbJGM5Y (ORCPT ); Wed, 7 Oct 2015 08:57:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33217 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbbJGM5V (ORCPT ); Wed, 7 Oct 2015 08:57:21 -0400 Date: Wed, 7 Oct 2015 13:56:31 +0100 From: Greg KH To: Srinivas Kandagatla Cc: maxime.ripard@free-electrons.com, linux-kernel@vger.kernel.org, andrew@lunn.ch, wxt@rock-chips.com, stefan.wahren@i2se.com, pantelis.antoniou@konsulko.com, maitysanchayan@gmail.com, p.zabel@pengutronix.de, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] nvmem: core: add sysfs file mode flag in nvmem_config Message-ID: <20151007125631.GC7962@kroah.com> References: <1444215536-10783-1-git-send-email-srinivas.kandagatla@linaro.org> <1444215664-10921-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444215664-10921-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 12:01:04PM +0100, Srinivas Kandagatla wrote: > This patch adds mode variable to nvmem_config structure which will allow > providers to specify the permissions for the sysfs binary file. > This mode is applied on top of root-only access permissions set by > the core. > > Having this flag would give more flexibility to providers to decide > which permissions to set on the sysfs binary file entry. And they will get it wrong, please don't do this. thanks, greg k-h