From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility Date: Wed, 7 Oct 2015 06:40:10 -0700 Message-ID: <20151007134010.GW23801@atomide.com> References: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de> <1444162070-22034-2-git-send-email-u.kleine-koenig@pengutronix.de> <5614CDAE.6070604@ti.com> <20151007075338.GH3982@pengutronix.de> <20151007102822.GT23801@atomide.com> <20151007110231.GL3982@pengutronix.de> <5614FD01.6090009@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <5614FD01.6090009@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Roger Quadros Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= List-Id: linux-omap@vger.kernel.org KiBSb2dlciBRdWFkcm9zIDxyb2dlcnFAdGkuY29tPiBbMTUxMDA3IDA0OjEyXToKPiBPbiAwNy8x MC8xNSAxNDowMiwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gPiBIZWxsbyBUb255LAo+ID4g Cj4gPiBPbiBXZWQsIE9jdCAwNywgMjAxNSBhdCAwMzo0MToxOUFNIC0wNzAwLCBUb255IExpbmRn cmVuIHdyb3RlOgo+ID4+ICogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5n dXRyb25peC5kZT4gWzE1MTAwNyAwMDo1N106Cj4gPj4+IE9uIFdlZCwgT2N0IDA3LCAyMDE1IGF0 IDEwOjQ1OjUwQU0gKzAzMDAsIFJvZ2VyIFF1YWRyb3Mgd3JvdGU6Cj4gPj4+Pgo+ID4+Pj4gSG93 IGFib3V0IHRoaXMgaW5zdGVhZD8KPiA+Pj4+Cj4gPj4+PiBOT1RFOiBBcGFydCBmcm9tIG1hdGNo aW5nIHRoZSByZWdpc3RlciBzZXR1cCB3aXRoIHRoZSBib290bG9hZGVyIHlvdSBhbHNvIG5lZWQg dG8KPiA+Pj4+IG1hdGNoIHRoZSBHUE1DIEZDTEsgZnJlcXVlbmN5IHVzZWQgYnkgdGhlIGJvb3Rs b2FkZXIgZWxzZSB0aGUgR1BNQyB0aW1pbmdzCj4gPj4+PiB3b24ndCBiZSBpZGVudGljYWwgd2l0 aCB0aGUgYm9vdGxvYWRlciB0aW1pbmdzLgo+ID4+PiBZZWFoLCBzb3VuZHMgYmV0dGVyLCB0aGFu a3MuCj4gPj4+Cj4gPj4+PiBBbHNvIHlvdSBtaWdodCBuZWVkIHRvIGJ1aWxkIHRoaXMgcGF0Y2gg b24gdG9wIG9mCj4gPj4+PiBodHRwOi8vYXJ0aWNsZS5nbWFuZS5vcmcvZ21hbmUubGludXgua2Vy bmVsLzIwNTQ3OTYKPiA+Pj4gSSB0YWxrZWQgdG8gVG9ueSBhYm91dCB0aGlzIHBhdGNoIHllc3Rl cmRheSBvbiBpcmMsIGJ1dCBJIGRpZG4ndCBmaW5kIGl0Cj4gPj4+IGluIHRoZSBhcmNoaXZlcyB5 ZXQgd2hlbiBJIHNlbnQgbXkgbWFpbC4KPiA+Pgo+ID4+IFllcyBzb3JyeSBoZXJlJ3MgYSByZXBv c3Qgd2l0aCB5b3VyIGFuZCBSb2dlcidzIGNoYW5nZXMgZm9sZGVkIGluIGFuZAo+ID4+IGVkaXRl ZCBhIGJpdC4gUHJvYmFibHkgYmVzdCB0byBrZWVwIHRoZW0gdG9nZXRoZXIgd2l0aCB0aGlzIHBh dGNoLgo+ID4+Cj4gPj4gRG9lcyB0aGUgZm9sbG93aW5nIGxvb2sgT0sgdG8geW91IGd1eXM/Cj4g PiBZZXMsCj4gPiBBY2tlZC1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0Bw ZW5ndXRyb25peC5kZT4KPiAKPiBMb29rcyBnb29kIHRvIG1lIHRvby4KCkFyZSB5b3UgT0sgaWYg SSB1c2UgeW91ciBBY2tlZC1ieSBmcm9tIHRoZSBwcmV2aW91cyB2ZXJzaW9uIG9uCnRoaXMgdXBk YXRlZCB2ZXJzaW9uPwoKUmVnYXJkcywKClRvbnkKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 7 Oct 2015 06:40:10 -0700 Subject: [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility In-Reply-To: <5614FD01.6090009@ti.com> References: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de> <1444162070-22034-2-git-send-email-u.kleine-koenig@pengutronix.de> <5614CDAE.6070604@ti.com> <20151007075338.GH3982@pengutronix.de> <20151007102822.GT23801@atomide.com> <20151007110231.GL3982@pengutronix.de> <5614FD01.6090009@ti.com> Message-ID: <20151007134010.GW23801@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Roger Quadros [151007 04:12]: > On 07/10/15 14:02, Uwe Kleine-K?nig wrote: > > Hello Tony, > > > > On Wed, Oct 07, 2015 at 03:41:19AM -0700, Tony Lindgren wrote: > >> * Uwe Kleine-K?nig [151007 00:57]: > >>> On Wed, Oct 07, 2015 at 10:45:50AM +0300, Roger Quadros wrote: > >>>> > >>>> How about this instead? > >>>> > >>>> NOTE: Apart from matching the register setup with the bootloader you also need to > >>>> match the GPMC FCLK frequency used by the bootloader else the GPMC timings > >>>> won't be identical with the bootloader timings. > >>> Yeah, sounds better, thanks. > >>> > >>>> Also you might need to build this patch on top of > >>>> http://article.gmane.org/gmane.linux.kernel/2054796 > >>> I talked to Tony about this patch yesterday on irc, but I didn't find it > >>> in the archives yet when I sent my mail. > >> > >> Yes sorry here's a repost with your and Roger's changes folded in and > >> edited a bit. Probably best to keep them together with this patch. > >> > >> Does the following look OK to you guys? > > Yes, > > Acked-by: Uwe Kleine-K?nig > > Looks good to me too. Are you OK if I use your Acked-by from the previous version on this updated version? Regards, Tony