From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>,
intel-gfx@lists.freedesktop.org,
Akash Goel <akash.goel@intel.com>
Subject: Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
Date: Wed, 7 Oct 2015 16:07:39 +0200 [thread overview]
Message-ID: <20151007140739.GH3383@phenom.ffwll.local> (raw)
In-Reply-To: <1444224951.9814.17.camel@intel.com>
On Wed, Oct 07, 2015 at 04:35:51PM +0300, Imre Deak wrote:
> On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote:
> > On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote:
> > > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> > > > From: Akash Goel <akash.goel@intel.com>
> > > >
> > > > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> > > > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> > >
> > > The comment about units in gen6_set_rps_thresholds() is outdated, so you
> > > could update that while at it. In any case this looks ok, so:
> > > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > In your previous review you noticed that Bspec is still outdated. Has that
> > been fixed meanwhile?
>
> Yep, Sagar pointed to a page in BSpec where the relevant clocks are
> defined ("Timestamp bases") and he also filed a change request in Bspec
> now to update the register description itself accordingly. Should've
> mentioned this when adding my r-b.
Awesome. Added a note about this and applied the patch.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-10-07 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 18:09 [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us Sagar Arun Kamble
2015-09-21 12:39 ` Imre Deak
2015-10-06 18:16 ` Imre Deak
2015-10-07 13:29 ` Daniel Vetter
2015-10-07 13:35 ` Imre Deak
2015-10-07 14:07 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007140739.GH3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akash.goel@intel.com \
--cc=ankitprasad.r.sharma@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.