From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
Date: Wed, 7 Oct 2015 17:24:03 +0200
Message-ID: <20151007152403.GG28811@8bytes.org>
References: <560D1C6E.2060803@suse.com>
 <560D278F.10801@redhat.com>
 <jpgbncixlts.fsf@linux.bootlegged.copy>
 <20151006102838.GD20886@8bytes.org>
 <jpg37xnj2tc.fsf@linux.bootlegged.copy>
 <20151007110335.GA28811@8bytes.org>
 <jpga8rupvy8.fsf@linux.bootlegged.copy>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
	Dirk =?iso-8859-1?Q?M=FCller?= <dmueller@suse.com>
To: Bandan Das <bsd@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from 8bytes.org ([81.169.241.247]:48183 "EHLO theia.8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753527AbbJGPYG (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 7 Oct 2015 11:24:06 -0400
Content-Disposition: inline
In-Reply-To: <jpga8rupvy8.fsf@linux.bootlegged.copy>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Oct 07, 2015 at 10:58:07AM -0400, Bandan Das wrote:
> Ok, looks like I am making some incorrect "vmx" assumptions here. What happens
> when we exit from L2 to L0, arent' we looking at the VMCB L1 is using to run
> L2 ? Wouldn't that trigger the warning if the host processor does not support
> nrips and the field is set ?

No, because the L1 hypervisor can't write to the shadow-vmcb, and this
is the only one where we _read_ next_rip from.



	Joerg