From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: PING: [PATCH v4 TRIVIAL 1/2] ARM: Enable GICv2m on 32-bit virt machine
Date: Wed, 7 Oct 2015 17:26:02 +0100 [thread overview]
Message-ID: <20151007162602.GL21513@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <56151372.8090306@arm.com>
On Wed, Oct 07, 2015 at 01:43:30PM +0100, Marc Zyngier wrote:
> On 07/10/15 12:29, Russell King - ARM Linux wrote:
> > On Wed, Oct 07, 2015 at 02:02:23PM +0300, Pavel Fedin wrote:
> >> 2/2 from this series has been ACKed and picked up by Marc Zynger. He
> >> told me that 1/2 is your area of competence.
> >
> > ... which is kind of funny, because all of ARM Ltd's platforms that
> > have PCIe on the board, and thus might have MSI, the PCIe is non-
> > functional. So, until SolidRun sent me an Armada 388 platform a few
> > weeks back, I had zero MSI platforms, and zero MSI knowledge.
> >
> > Just because code falls into a particular area of the tree does not
> > mean that the person who's looking after that area knows everything
> > inside out - especially when it comes to architecture maintanence
> > and the code in that subtree covers virtually every technology out
> > there, and the maintainer is kept functional hardware-starved [*].
> >
> > Now, the Armada 388 doesn't use the GIC for MSI, but uses its own
> > interrupt controller. I haven't yet worked out which bits of the
> > kernel are being used to provide this functionality yet, but I know
> > it works. What I don't want to do is to merge your patch and then
> > have my one and only MSI platform break because of it, so what I'm
> > looking for is an assurance that this has had some exposure on
> > non-GIC MSI platforms, or has been reviewed with this in mind.
> >
> > We're having far too many regressions of the kind of "let's get X
> > working on platform Y which then causes platform Z to break".
> >
> >
> > * - I'm not saying that I want more hardware; I've been out of physical
> > space for new hardware for some time, and the few extra platforms I've
> > received recently are having to be stacked on top of each other - which
> > isn't good when they're bare boards. It would be nice, however, if the
> > hardware I did have was fully functional!
> >
>
> The generic MSI domain (which is what asm-generic/msi.h is about -
> nothing GIC specific about it) is entirely isolated from the rest of the
> MSI infrastructure used on 32bit ARM, and is very unlikely to introduce
> any regression.
That's good to hear. Okay, let's get this patch in the patch system then,
and I'll see whether it has any effect on Armada 388.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-07 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 8:45 PING: [PATCH v4 TRIVIAL 1/2] ARM: Enable GICv2m on 32-bit virt machine Pavel Fedin
2015-10-07 10:23 ` Russell King - ARM Linux
2015-10-07 11:02 ` Pavel Fedin
2015-10-07 11:29 ` Russell King - ARM Linux
2015-10-07 12:43 ` Marc Zyngier
2015-10-07 16:26 ` Russell King - ARM Linux [this message]
2015-10-07 12:14 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007162602.GL21513@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.