From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Wed, 7 Oct 2015 17:50:46 +0100 Subject: [PATCH] nvmem: core: make default user binary file root-access only In-Reply-To: <1444235714-24365-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1444235714-24365-1-git-send-email-srinivas.kandagatla@linaro.org> Message-ID: <20151007165046.GC12099@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 07, 2015 at 05:35:14PM +0100, Srinivas Kandagatla wrote: > As required by many providers like at24/at25/mxs-ocotp/qfprom, which would > want to allow root-only to read/write the nvmem content. > So making the defaults to be root-only access which can prevent normal > users from reading the nvmem data. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 6fd4e5a..4d2e476 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -112,7 +112,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, > static struct bin_attribute bin_attr_rw_nvmem = { > .attr = { > .name = "nvmem", > - .mode = S_IWUSR | S_IRUGO, > + .mode = S_IWUSR | S_IRUSR, > }, > .read = bin_attr_nvmem_read, > .write = bin_attr_nvmem_write, > @@ -136,7 +136,7 @@ static const struct attribute_group *nvmem_rw_dev_groups[] = { > static struct bin_attribute bin_attr_ro_nvmem = { > .attr = { > .name = "nvmem", > - .mode = S_IRUGO, > + .mode = S_IRUSR, > }, > .read = bin_attr_nvmem_read, > }; How about using BIN_ATTR_RO() and friends instead, that way I _know_ you got the permissions correct as it's impossible to get them wrong by using those macros. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755325AbbJGQux (ORCPT ); Wed, 7 Oct 2015 12:50:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55561 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274AbbJGQuu (ORCPT ); Wed, 7 Oct 2015 12:50:50 -0400 Date: Wed, 7 Oct 2015 17:50:46 +0100 From: Greg KH To: Srinivas Kandagatla Cc: maxime.ripard@free-electrons.com, linux-kernel@vger.kernel.org, andrew@lunn.ch, wxt@rock-chips.com, stefan.wahren@i2se.com, pantelis.antoniou@konsulko.com, maitysanchayan@gmail.com, p.zabel@pengutronix.de, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] nvmem: core: make default user binary file root-access only Message-ID: <20151007165046.GC12099@kroah.com> References: <1444235714-24365-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444235714-24365-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 05:35:14PM +0100, Srinivas Kandagatla wrote: > As required by many providers like at24/at25/mxs-ocotp/qfprom, which would > want to allow root-only to read/write the nvmem content. > So making the defaults to be root-only access which can prevent normal > users from reading the nvmem data. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/nvmem/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 6fd4e5a..4d2e476 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -112,7 +112,7 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj, > static struct bin_attribute bin_attr_rw_nvmem = { > .attr = { > .name = "nvmem", > - .mode = S_IWUSR | S_IRUGO, > + .mode = S_IWUSR | S_IRUSR, > }, > .read = bin_attr_nvmem_read, > .write = bin_attr_nvmem_write, > @@ -136,7 +136,7 @@ static const struct attribute_group *nvmem_rw_dev_groups[] = { > static struct bin_attribute bin_attr_ro_nvmem = { > .attr = { > .name = "nvmem", > - .mode = S_IRUGO, > + .mode = S_IRUSR, > }, > .read = bin_attr_nvmem_read, > }; How about using BIN_ATTR_RO() and friends instead, that way I _know_ you got the permissions correct as it's impossible to get them wrong by using those macros. thanks, greg k-h