Re: [PATCH 3/4] power:bq27x00: don't fill system log by missing battery

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1257 bytes --]

On Wednesday 07 October 2015 20:42:38 H. Nikolaus Schaller wrote:
> From: NeilBrown <neilb@suse.de>
> 
> Print message that battery is not calibrated only during debug build
> but not during normal operation.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  drivers/power/bq27x00_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/bq27x00_battery.c
> b/drivers/power/bq27x00_battery.c index 8287261f..709d1e4 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -491,7 +491,7 @@ static void bq27x00_update(struct
> bq27x00_device_info *di) if (cache.flags >= 0) {
>  		if (!is_bq27500 && !is_bq27425 && !is_bq27742 && !is_bq27510
>  				&& (cache.flags & BQ27000_FLAG_CI)) {
> -			dev_info(di->dev, "battery is not calibrated! ignoring 
capacity
> values\n"); +			dev_dbg(di->dev, "battery is not calibrated!
> ignoring capacity values\n"); cache.capacity = -ENODATA;
>  			cache.energy = -ENODATA;
>  			cache.time_to_empty = -ENODATA;

Hi! I think that better approach would be to use WARN_ONCE or similar 
macro. Still use INFO level, just warn about this problem only once...

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]