From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbbJHAZs (ORCPT ); Wed, 7 Oct 2015 20:25:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:40852 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbbJHAZr (ORCPT ); Wed, 7 Oct 2015 20:25:47 -0400 Date: Thu, 8 Oct 2015 02:25:43 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Scott Feldman , Jiri Pirko , Florian Fainelli , Neil Armstrong , Sergei Shtylyov Subject: Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Message-ID: <20151008002543.GB31267@lunn.ch> References: <1444261711-1829-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1444261711-1829-5-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444261711-1829-5-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 07:48:29PM -0400, Vivien Didelot wrote: > Push the prepare phase for FDB operations down to the DSA drivers, with > a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6171.c | 1 + > drivers/net/dsa/mv88e6352.c | 1 + > drivers/net/dsa/mv88e6xxx.c | 10 ++++++++++ > drivers/net/dsa/mv88e6xxx.h | 3 +++ > include/net/dsa.h | 4 ++++ > net/dsa/slave.c | 7 +++++-- > 6 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c > index c95cfab..ca3330a 100644 > --- a/drivers/net/dsa/mv88e6171.c > +++ b/drivers/net/dsa/mv88e6171.c > @@ -121,6 +121,7 @@ struct dsa_switch_driver mv88e6171_switch_driver = { > .port_vlan_add = mv88e6xxx_port_vlan_add, > .port_vlan_del = mv88e6xxx_port_vlan_del, > .vlan_getnext = mv88e6xxx_vlan_getnext, > + .port_fdb_prepare = mv88e6xxx_port_fdb_prepare, Hi Vivien Bike shedding a bit, but i would call this mv88e6xxx_port_fdb_prepare_add. > .port_fdb_add = mv88e6xxx_port_fdb_add, > .port_fdb_del = mv88e6xxx_port_fdb_del, > .port_fdb_getnext = mv88e6xxx_port_fdb_getnext, Taking a theoretical example, say mv88e6xxx_port_fdb_getnext needed a prepare call to allocate memory to put the returned ATU into. What would you call that? mv88e6xxx_port_fdb_prepare_add and mv88e6xxx_port_fdb_prepare_getnext just seems unambiguous and future proof. Andrew