From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: skein: remove extra indentation
Date: Wed, 7 Oct 2015 18:26:12 -0700 [thread overview]
Message-ID: <20151008012611.GA20044@deepa-ubuntu> (raw)
In-Reply-To: <alpine.DEB.2.10.1510072020130.2482@hadrien>
On Wed, Oct 07, 2015 at 08:20:38PM +0100, Julia Lawall wrote:
> On Wed, 7 Oct 2015, Deepa Dinamani wrote:
>
> > Remove second leading indent of code in do/while macro blocks.
> >
> > This patch fixes the checkpatch.pl warning:
> >
> > WARNING: suspect code indent for conditional statements
> >
> > Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> > ---
> > drivers/staging/skein/skein_block.c | 40 ++++++++++++++++++-------------------
> > 1 file changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c
> > index b0cd935..09d37d5 100644
> > --- a/drivers/staging/skein/skein_block.c
> > +++ b/drivers/staging/skein/skein_block.c
> > @@ -96,16 +96,16 @@ do { \
> > #endif
> > #define R256_8_ROUNDS(R) \
> > do { \
>
> Could it be nicer to indent the do instead?
>
> julia
Is reducing the size of the diff a primary goal, or is it a coding
style preference? Both approaches are used by other macros in this
same source file. Should they all be changed for consistency?
deepa
> > - R256(0, 1, 2, 3, R_256_0, 8 * (R) + 1); \
> > - R256(0, 3, 2, 1, R_256_1, 8 * (R) + 2); \
> > - R256(0, 1, 2, 3, R_256_2, 8 * (R) + 3); \
> > - R256(0, 3, 2, 1, R_256_3, 8 * (R) + 4); \
> > - I256(2 * (R)); \
> > - R256(0, 1, 2, 3, R_256_4, 8 * (R) + 5); \
> > - R256(0, 3, 2, 1, R_256_5, 8 * (R) + 6); \
> > - R256(0, 1, 2, 3, R_256_6, 8 * (R) + 7); \
> > - R256(0, 3, 2, 1, R_256_7, 8 * (R) + 8); \
> > - I256(2 * (R) + 1); \
> > + R256(0, 1, 2, 3, R_256_0, 8 * (R) + 1); \
> > + R256(0, 3, 2, 1, R_256_1, 8 * (R) + 2); \
> > + R256(0, 1, 2, 3, R_256_2, 8 * (R) + 3); \
> > + R256(0, 3, 2, 1, R_256_3, 8 * (R) + 4); \
> > + I256(2 * (R)); \
> > + R256(0, 1, 2, 3, R_256_4, 8 * (R) + 5); \
> > + R256(0, 3, 2, 1, R_256_5, 8 * (R) + 6); \
> > + R256(0, 1, 2, 3, R_256_6, 8 * (R) + 7); \
> > + R256(0, 3, 2, 1, R_256_7, 8 * (R) + 8); \
> > + I256(2 * (R) + 1); \
> > } while (0)
> >
> > #define R256_UNROLL_R(NN) \
> > @@ -187,16 +187,16 @@ do { \
> > #endif /* end of looped code definitions */
> > #define R512_8_ROUNDS(R) /* do 8 full rounds */ \
> > do { \
> > - R512(0, 1, 2, 3, 4, 5, 6, 7, R_512_0, 8 * (R) + 1); \
> > - R512(2, 1, 4, 7, 6, 5, 0, 3, R_512_1, 8 * (R) + 2); \
> > - R512(4, 1, 6, 3, 0, 5, 2, 7, R_512_2, 8 * (R) + 3); \
> > - R512(6, 1, 0, 7, 2, 5, 4, 3, R_512_3, 8 * (R) + 4); \
> > - I512(2 * (R)); \
> > - R512(0, 1, 2, 3, 4, 5, 6, 7, R_512_4, 8 * (R) + 5); \
> > - R512(2, 1, 4, 7, 6, 5, 0, 3, R_512_5, 8 * (R) + 6); \
> > - R512(4, 1, 6, 3, 0, 5, 2, 7, R_512_6, 8 * (R) + 7); \
> > - R512(6, 1, 0, 7, 2, 5, 4, 3, R_512_7, 8 * (R) + 8); \
> > - I512(2 * (R) + 1); /* and key injection */ \
> > + R512(0, 1, 2, 3, 4, 5, 6, 7, R_512_0, 8 * (R) + 1); \
> > + R512(2, 1, 4, 7, 6, 5, 0, 3, R_512_1, 8 * (R) + 2); \
> > + R512(4, 1, 6, 3, 0, 5, 2, 7, R_512_2, 8 * (R) + 3); \
> > + R512(6, 1, 0, 7, 2, 5, 4, 3, R_512_3, 8 * (R) + 4); \
> > + I512(2 * (R)); \
> > + R512(0, 1, 2, 3, 4, 5, 6, 7, R_512_4, 8 * (R) + 5); \
> > + R512(2, 1, 4, 7, 6, 5, 0, 3, R_512_5, 8 * (R) + 6); \
> > + R512(4, 1, 6, 3, 0, 5, 2, 7, R_512_6, 8 * (R) + 7); \
> > + R512(6, 1, 0, 7, 2, 5, 4, 3, R_512_7, 8 * (R) + 8); \
> > + I512(2 * (R) + 1); /* and key injection */ \
> > } while (0)
> > #define R512_UNROLL_R(NN) \
> > ((SKEIN_UNROLL_512 == 0 && \
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151007170600.GA24764%40deepa-ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >
next prev parent reply other threads:[~2015-10-08 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 17:06 [PATCH 1/2] staging: skein: remove extra indentation Deepa Dinamani
2015-10-07 19:20 ` [Outreachy kernel] " Julia Lawall
2015-10-08 1:26 ` Deepa Dinamani [this message]
2015-10-08 6:54 ` Julia Lawall
2015-10-08 9:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008012611.GA20044@deepa-ubuntu \
--to=deepa.kernel@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.