All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Subject: Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match
Date: Thu, 8 Oct 2015 10:51:33 +0200	[thread overview]
Message-ID: <20151008085132.GB4729@gmail.com> (raw)
In-Reply-To: <5615AA55.5000203@redhat.com>


* Prarit Bhargava <prarit@redhat.com> wrote:

> re-ping on this.  Just making sure this wasn't dropped on the floor.

So I didn't apply it back when I saw your patch because I didn't see where you 
addressed/analyzed the second paragraph of hpa's review:

  "The downside with set is that it only sets a single byte, the upside is that it 
   always outputs 0 or 1, and apparently if the output variable is your bool gcc 
   can use that for optimization."

That's a valid concern and should be addressed.

Thanks,

	Ingo

  reply	other threads:[~2015-10-08  8:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-19 17:18 [PATCH] x86, bitops, variable_test_bit should return 1 not -1 on a match Prarit Bhargava
2015-08-21  6:51 ` Ingo Molnar
2015-08-21  8:08   ` H. Peter Anvin
2015-08-21 11:53     ` Prarit Bhargava
2015-08-24 18:22     ` [PATCH v2] " Prarit Bhargava
2015-10-07 23:27       ` Prarit Bhargava
2015-10-08  8:51         ` Ingo Molnar [this message]
2015-10-08 11:48     ` [PATCH] " Prarit Bhargava
2015-08-21 11:50   ` Prarit Bhargava
2015-08-22  9:14     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008085132.GB4729@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=prarit@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.