All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: outreachy-kernel@googlegroups.com,
	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Do not DMA on the stack
Date: Thu, 8 Oct 2015 10:43:15 +0100	[thread overview]
Message-ID: <20151008094315.GB6793@kroah.com> (raw)
In-Reply-To: <5271552.eVnCbIod9Q@wuerfel>

On Tue, Oct 06, 2015 at 09:25:21PM +0200, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 21:07:11 Ksenija Stanojevic wrote:
> > Fix error "doing DMA on the stack" by using kzalloc for buffer
> > allocation.
> > Issue found by smatch.
> > 
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> > 
> 
> Looks correct to me now,
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
> I have a vague feeling that there ought to be a nicer way to do it
> without having to duplicate all those kmalloc calls, but I didn't
> find an existing USB driver API for that. I'm sure Greg will tell us
> if there is one.

Nope, unfortunatly, it's the only way to do this.

greg k-h


  reply	other threads:[~2015-10-08  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 19:07 [PATCH v2] Staging: rtl8192u: Do not DMA on the stack Ksenija Stanojevic
2015-10-06 19:25 ` [Outreachy kernel] " Arnd Bergmann
2015-10-08  9:43   ` Greg KH [this message]
2015-10-08  9:45 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008094315.GB6793@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.