Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning

[Shivani Bhardwaj <shivanib134@gmail.com>]

On Thu, Oct 08, 2015 at 11:25:22AM +0100, Julia Lawall wrote:
> On Thu, 8 Oct 2015, Shivani Bhardwaj wrote:
> 
> > Fixed the warning - line over 80 characters generated by checkpatch by
> > breaking the line at appropriate places so that the code looks more
> > readable and good.
> >
> > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> > index a7a2351..382b515 100644
> > --- a/drivers/staging/sm750fb/ddk750_dvi.c
> > +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> > @@ -46,9 +46,10 @@ int dviInit(
> >
> >  	pCurrentDviCtrl = g_dcftSupportedDviController;
> >  	if (pCurrentDviCtrl->pfnInit != NULL) {
> > -		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> > -						vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> > -						pllFilterEnable, pllFilterValue);
> > +		return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
> > +			dualEdgeClkSelect, hsyncEnable, vsyncEnable,
> > +			deskewEnable, deskewSetting, continuousSyncEnable,
> > +					pllFilterEnable, pllFilterValue);
> 
> It looks like the arguments are not all lined up - the last ones are more
> indented than the others.  The real problem would be the ariable names...
> 
> julia
> 

So, should I indent the last line in accordance with the previous ones?
Will that work fine? I'm sorry, I do not understand what would be the
problem with variable names.

Thanks
Shivani

> >  	}
> >  	return -1; /* error */
> >  }
> > --
> > 2.1.0
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >