From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wtarreau.pck.nerim.net ([62.212.114.60]:49398 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757465AbbJHNBA (ORCPT ); Thu, 8 Oct 2015 09:01:00 -0400 Date: Thu, 8 Oct 2015 15:00:43 +0200 From: Willy Tarreau To: Ben Hutchings Cc: Guenter Roeck , stable , Greg Kroah-Hartman , dingtianhong Subject: Re: Build errors in v3.10-stable-queue Message-ID: <20151008130043.GA4522@1wt.eu> References: <56071A11.5000800@roeck-us.net> <1444308572.2956.254.camel@decadent.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444308572.2956.254.camel@decadent.org.uk> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Oct 08, 2015 at 01:49:32PM +0100, Ben Hutchings wrote: > On Sat, 2015-09-26 at 15:20 -0700, Guenter Roeck wrote: > > drivers/net/bonding/bond_main.c: In function ???bond_get_old_active???: > > drivers/net/bonding/bond_main.c:884:33: error: macro "bond_for_each_slave" requires 3 arguments, but only 2 given > > drivers/net/bonding/bond_main.c:884:2: error: ???bond_for_each_slave??? undeclared (first use in this function) > > drivers/net/bonding/bond_main.c:884:2: note: each undeclared identifier is reported only once for each function it appears in > > drivers/net/bonding/bond_main.c:884:35: error: expected ???;??? before ???{??? token > > > > This affects a large number of builds. > > > > Culprit is 'bonding: correct the MAC address for "follow" > > fail_over_mac policy', which may need a backport. > > bond_for_each_slave() needs an int parameter for a counter. > > Untested backport attached, based on what I did for 3.2. I agree with the fix, it's similar to what I proposed (except that you actually did the patch of course). Willy