From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZkEYR-0002yR-IM
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 13:01:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZkEXm-0006T2-4r
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 13:00:31 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:53618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZkEXl-0006Sg-VP
	for qemu-devel@nongnu.org; Thu, 08 Oct 2015 12:59:50 -0400
Date: Thu, 8 Oct 2015 18:12:47 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20151008161247.GA7335@aurel32.net>
References: <1443788657-14537-1-git-send-email-james.hogan@imgtec.com>
	<1443788657-14537-2-git-send-email-james.hogan@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443788657-14537-2-git-send-email-james.hogan@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/6] tcg-opc.h: Simplify
	debug_insn_start def
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>
Cc: Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On 2015-10-02 13:24, James Hogan wrote:
> We already have a TLADDR_ARGS definition, so rearrange the order
> slightly and use it in the definition of debug_insn_start, instead of
> having an #ifdef.
> 
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tcg-opc.h | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Note that it will conflict with the "tcg: Rename debug_insn_start to
insn_start" patch that Richard has posted on the list, but it should
be trivial to solve it.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net