All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Inconsistencies in commands regarding load_addr
Date: Thu, 08 Oct 2015 23:29:01 +0200	[thread overview]
Message-ID: <20151008212902.065EE382CD2@gemini.denx.de> (raw)
In-Reply-To: <56167DB6.3000508@wwwdotorg.org>

Dear Stephen,

In message <56167DB6.3000508@wwwdotorg.org> you wrote:
>
> >> What's the expected correct behavior here?
> >
> > After successful loading the data to memory, load_addr should be set
> > correctly, for all commands.  In the error case, the value of
> > load_addr is undefined.
> 
> Is this documented anywhere? If not, I'm not convinced that there's a 
> contract to be followed; it "just happens" that some filesystem-related 
> commands work(ed) that way (and as Beno?t pointed out, apparently some 
> don't irrespective of the mentioned patch).

I'm afraid it's not documented, but it is what I would consider a sane
and consistent behaviour.  If we intend to implement POLA [1] (and I
very much think we should), this is how U-Boot should behave.


[1] https://en.wikipedia.org/wiki/Principle_of_least_astonishment


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What we hope ever to do with ease, we must learn  first  to  do  with
diligence.                                           - Samuel Johnson

  reply	other threads:[~2015-10-08 21:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 15:00 [U-Boot] Inconsistencies in commands regarding load_addr Benoît Thébaudeau
2015-10-06 18:09 ` Stephen Warren
2015-10-06 19:07   ` Benoît Thébaudeau
2015-10-08  4:40 ` Wolfgang Denk
2015-10-08 14:29   ` Stephen Warren
2015-10-08 21:29     ` Wolfgang Denk [this message]
2015-10-09  8:28       ` Benoît Thébaudeau
2015-10-09 13:18         ` Wolfgang Denk
2015-10-09 14:01           ` Benoît Thébaudeau
2015-10-09 14:55             ` Wolfgang Denk
2015-10-09 15:36         ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151008212902.065EE382CD2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.