From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6203214669775110144 X-Received: by 10.68.165.5 with SMTP id yu5mr9173891pbb.1.1444364053841; Thu, 08 Oct 2015 21:14:13 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.98.238 with SMTP id o101ls1553901qge.32.gmail; Thu, 08 Oct 2015 21:14:13 -0700 (PDT) X-Received: by 10.140.144.215 with SMTP id 206mr9235525qhq.6.1444364053126; Thu, 08 Oct 2015 21:14:13 -0700 (PDT) Return-Path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTPS id q68si1181128ywf.0.2015.10.08.21.14.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 21:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Received: from localhost (mobile-166-176-186-92.mycingular.net [166.176.186.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9B2971BB0; Fri, 9 Oct 2015 04:14:11 +0000 (UTC) Date: Thu, 8 Oct 2015 21:14:02 -0700 From: Greg KH To: Shivani Bhardwaj Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level Message-ID: <20151009041402.GA31030@kroah.com> References: <20151008100054.GA5215@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151008100054.GA5215@ubuntu> User-Agent: Mutt/1.5.24 (2015-08-30) On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote: > Fixed the warning : printk() should include KERN_ facility level > generated by checkpatch by using the function pr_info() instead of > printk(). > > Signed-off-by: Shivani Bhardwaj > --- > drivers/staging/sm750fb/ddk750_help.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c > index 9637dd3..e72a29c 100644 > --- a/drivers/staging/sm750fb/ddk750_help.c > +++ b/drivers/staging/sm750fb/ddk750_help.c > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > devId750 = devId; > revId750 = revId; > if (revId == 0xfe) > - printk("found sm750le\n"); > + pr_info("found sm750le\n"); Can you use dev_info() here instead?