From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6203214669775110144 X-Received: by 10.66.102.38 with SMTP id fl6mr9312552pab.48.1444372142988; Thu, 08 Oct 2015 23:29:02 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.50.25.166 with SMTP id d6ls413214igg.43.canary; Thu, 08 Oct 2015 23:29:02 -0700 (PDT) X-Received: by 10.66.124.131 with SMTP id mi3mr9877036pab.32.1444372142687; Thu, 08 Oct 2015 23:29:02 -0700 (PDT) Return-Path: Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com. [2607:f8b0:400e:c03::22a]) by gmr-mx.google.com with ESMTPS id wl2si6732pab.1.2015.10.08.23.29.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 23:29:02 -0700 (PDT) Received-SPF: pass (google.com: domain of shivanib134@gmail.com designates 2607:f8b0:400e:c03::22a as permitted sender) client-ip=2607:f8b0:400e:c03::22a; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of shivanib134@gmail.com designates 2607:f8b0:400e:c03::22a as permitted sender) smtp.mailfrom=shivanib134@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x22a.google.com with SMTP id ve7so18932132pab.2 for ; Thu, 08 Oct 2015 23:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=JZWXdeUMdX0/t/80opWFYkYP973HuFxdwNIlNYY8ESs=; b=a8KnGlP+jkb89jz62LQwESFFPunYnVvWhEDKk+PDXZuRcUvmfvCEOdfDpp6KOAw6jz DfaWiYj3UG+TzIo3WWiGBwNYawQHXebkgkyf+z65eUgCrCj1JIReVuyCkB0/5Ed85jyE M1mmNTCYpjgdQqw8z6qyVcHeAorTFp+tQGEpgZN2B1BL4WN1BiiMSCLmuZOAWlPUCYwY umreVRFTagyTGBjMKBxpPqiXRaMCQ4rZufmSL+X4GqEE3LkiHnR6wA0LolyqVKMPx7q+ aIdz2r7ebkdc/vxEX/NgCrPRaSa5JoJNyTAVbN69o5WgoNp47fJvQWnpA1DuJar6gtlM dgpQ== X-Received: by 10.66.251.232 with SMTP id zn8mr13108970pac.80.1444372142575; Thu, 08 Oct 2015 23:29:02 -0700 (PDT) Return-Path: Received: from ubuntu ([124.124.47.116]) by smtp.gmail.com with ESMTPSA id u3sm116548pbs.33.2015.10.08.23.29.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 23:29:01 -0700 (PDT) Date: Fri, 9 Oct 2015 11:58:51 +0530 From: Shivani Bhardwaj To: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level Message-ID: <20151009062851.GA38872@ubuntu> References: <20151008100054.GA5215@ubuntu> <20151009041402.GA31030@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151009041402.GA31030@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) On Thu, Oct 08, 2015 at 09:14:02PM -0700, Greg KH wrote: > On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote: > > Fixed the warning : printk() should include KERN_ facility level > > generated by checkpatch by using the function pr_info() instead of > > printk(). > > > > Signed-off-by: Shivani Bhardwaj > > --- > > drivers/staging/sm750fb/ddk750_help.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c > > index 9637dd3..e72a29c 100644 > > --- a/drivers/staging/sm750fb/ddk750_help.c > > +++ b/drivers/staging/sm750fb/ddk750_help.c > > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > > devId750 = devId; > > revId750 = revId; > > if (revId == 0xfe) > > - printk("found sm750le\n"); > > + pr_info("found sm750le\n"); > > Can you use dev_info() here instead? Yes, OK. I'm sending version 2. :) Thank you