From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/8] drm/i915: Migrate to safe iterators in error state capture Date: Fri, 9 Oct 2015 10:27:12 +0200 Message-ID: <20151009082712.GG26718@phenom.ffwll.local> References: <1444329100-19189-1-git-send-email-tomas.elf@intel.com> <1444329100-19189-3-git-send-email-tomas.elf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A2E66EE06 for ; Fri, 9 Oct 2015 01:24:20 -0700 (PDT) Received: by wicfx3 with SMTP id fx3so59817052wic.1 for ; Fri, 09 Oct 2015 01:24:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1444329100-19189-3-git-send-email-tomas.elf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tomas Elf Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDgsIDIwMTUgYXQgMDc6MzE6MzRQTSArMDEwMCwgVG9tYXMgRWxmIHdyb3Rl Ogo+IFVzaW5nIHNhZmUgbGlzdCBpdGVyYXRvcnMgYWxsZXZpYXRlcyB0aGUgcHJvYmxlbSBvZiB1 bnN5bmNocm9uaXplZCBkcml2ZXIgbGlzdAo+IG1hbmlwdWxhdGlvbnMgd2hpbGUgZXJyb3Igc3Rh dGUgY2FwdHVyZSBpcyBpbiB0aGUgcHJvY2VzcyBvZiB0cmF2ZXJzaW5nIGxpc3RzLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFRvbWFzIEVsZiA8dG9tYXMuZWxmQGludGVsLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYyB8IDM4ICsrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAx OSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9ncHVfZXJyb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMKPiBp bmRleCAyZjA0ZTRmLi4zMmMxNzk5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ3B1X2Vycm9yLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9l cnJvci5jCj4gQEAgLTcxOCwxMCArNzE4LDEwIEBAIHN0YXRpYyB2b2lkIGNhcHR1cmVfYm8oc3Ry dWN0IGRybV9pOTE1X2Vycm9yX2J1ZmZlciAqZXJyLAo+ICBzdGF0aWMgdTMyIGNhcHR1cmVfYWN0 aXZlX2JvKHN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZmZXIgKmVyciwKPiAgCQkJICAgICBpbnQg Y291bnQsIHN0cnVjdCBsaXN0X2hlYWQgKmhlYWQpCj4gIHsKPiAtCXN0cnVjdCBpOTE1X3ZtYSAq dm1hOwo+ICsJc3RydWN0IGk5MTVfdm1hICp2bWEsICp0bXB2bWE7Cj4gIAlpbnQgaSA9IDA7Cj4g IAo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsIGhlYWQsIG1tX2xpc3QpIHsKPiArCWxpc3Rf Zm9yX2VhY2hfZW50cnlfc2FmZSh2bWEsIHRtcHZtYSwgaGVhZCwgbW1fbGlzdCkgewoKX3NhZmUg aXNuJ3Qgc2FmZSBhZ2FpbnN0IGFueXRoaW5nLCBpdCdzIG9ubHkgc2FmZSBhZ2FpbnN0IHJlbW92 YWwgb2YgdGhlCmN1cnJlbnQgbGlzdCBpdGVtIGRvbmUgd2l0aCBhIGxpc3RfZGVsL2xpc3RfbW92 ZSBmcm9tIHRoaXMgdGhyZWFkLiBJLmUuCnRoZSBvbmx5IHRoaW5nIGl0IGRvZXMgaXMgaGF2ZSBh IHRlbXBvcmFyeSBwb2ludGVyIHRvIHRoZSBuZXh0IGxpc3QKZWxlbWVudCBzbyBpZiB5b3UgZGVs ZXRlIHRoZSBjdXJyZW50IG9uZSBpdCB3b24ndCBmYWxsIG92ZXIuCgpJdCBkb2Vzbid0IHByb3Rl Y3QgYWdhaW5zdCBhbnl0aGluZyBlbHNlLCBhbmQgZXNwZWNpYWxseSBub3QgYWdhaW5zdCBvdGhl cgp0aHJlYWRzIHRvdGFsbHkgc3RvbXBpbmcgdGhlIGxpc3QuCgpTbyB3ZSBuZWVkIHByb3BlciBw cm90ZWN0aW9uIGZvciB0aGVzZSBsaXN0cywgaW5kZXBlbmRlbnQgb2YKZGV2LT5zdHJ1Y3RfbXV0 ZXguIFRoZSBsZWFzdCBpbnZhc2l2ZSB3YXkgdG8gZG8gdGhhdCBpcyBwcm9iYWJseSByY3UsCndo aWNoIG9ubHkgcmVxdWlyZXMgdXMgdGhhdCB3ZSByZWxlYXNlIHRoZSBtZW1vcnkgZm9yIGFueSBv YmplY3Qgc2l0dGluZwpvbiB0aGVzZSBsaXN0cyB3aXRoIGtmcmVlX3JjdSBpbnN0ZWFkIG9mIG5v cm1hbCBrZnJlZS4gQW5vdGhlciBvcHRpb24KbWlnaHQgYmUgYSBzcGlubG9jaywgYnV0IHRoYXQg d291bGQgYmUgYSBsb3QgbW9yZSBpbnZhc2l2ZSwgYW5kIENocmlzCndvbid0IGxpa2UgdGhlIGV4 ZWNidWYgb3ZlcmhlYWQgdGhpcyBjYXVzZXMgOy0pCi1EYW5pZWwKCj4gIAkJY2FwdHVyZV9ibyhl cnIrKywgdm1hKTsKPiAgCQlpZiAoKytpID09IGNvdW50KQo+ICAJCQlicmVhazsKPiBAQCAtNzM0 LDE3ICs3MzQsMTcgQEAgc3RhdGljIHUzMiBjYXB0dXJlX3Bpbm5lZF9ibyhzdHJ1Y3QgZHJtX2k5 MTVfZXJyb3JfYnVmZmVyICplcnIsCj4gIAkJCSAgICAgaW50IGNvdW50LCBzdHJ1Y3QgbGlzdF9o ZWFkICpoZWFkLAo+ICAJCQkgICAgIHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtKQo+ICB7 Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICsJc3RydWN0IGRybV9pOTE1 X2dlbV9vYmplY3QgKm9iaiwgKnRtcG9iajsKPiAgCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZm ZXIgKiBjb25zdCBmaXJzdCA9IGVycjsKPiAgCXN0cnVjdCBkcm1faTkxNV9lcnJvcl9idWZmZXIg KiBjb25zdCBsYXN0ID0gZXJyICsgY291bnQ7Cj4gIAo+IC0JbGlzdF9mb3JfZWFjaF9lbnRyeShv YmosIGhlYWQsIGdsb2JhbF9saXN0KSB7Cj4gLQkJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gKwls aXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUob2JqLCB0bXBvYmosIGhlYWQsIGdsb2JhbF9saXN0KSB7 Cj4gKwkJc3RydWN0IGk5MTVfdm1hICp2bWEsICp0bXB2bWE7Cj4gIAo+ICAJCWlmIChlcnIgPT0g bGFzdCkKPiAgCQkJYnJlYWs7Cj4gIAo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkodm1hLCAmb2Jq LT52bWFfbGlzdCwgdm1hX2xpbmspCj4gKwkJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHZtYSwg dG1wdm1hLCAmb2JqLT52bWFfbGlzdCwgdm1hX2xpbmspCj4gIAkJCWlmICh2bWEtPnZtID09IHZt ICYmIHZtYS0+cGluX2NvdW50ID4gMCkKPiAgCQkJCWNhcHR1cmVfYm8oZXJyKyssIHZtYSk7Cj4g IAl9Cj4gQEAgLTk1OCwxMyArOTU4LDEzIEBAIHN0YXRpYyB2b2lkIGk5MTVfZ2VtX3JlY29yZF9h Y3RpdmVfY29udGV4dChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+ICAJCQkJCSAgIHN0 cnVjdCBkcm1faTkxNV9lcnJvcl9yaW5nICplcmluZykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXN0cnVjdCBk cm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAq b2JqLCAqdG1wb2JqOwo+ICAKPiAgCS8qIEN1cnJlbnRseSByZW5kZXIgcmluZyBpcyB0aGUgb25s eSBIVyBjb250ZXh0IHVzZXIgKi8KPiAgCWlmIChyaW5nLT5pZCAhPSBSQ1MgfHwgIWVycm9yLT5j Y2lkKQo+ICAJCXJldHVybjsKPiAgCj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KG9iaiwgJmRldl9w cml2LT5tbS5ib3VuZF9saXN0LCBnbG9iYWxfbGlzdCkgewo+ICsJbGlzdF9mb3JfZWFjaF9lbnRy eV9zYWZlKG9iaiwgdG1wb2JqLCAmZGV2X3ByaXYtPm1tLmJvdW5kX2xpc3QsIGdsb2JhbF9saXN0 KSB7Cj4gIAkJaWYgKCFpOTE1X2dlbV9vYmpfZ2d0dF9ib3VuZChvYmopKQo+ICAJCQljb250aW51 ZTsKPiAgCj4gQEAgLTk3OSw3ICs5NzksNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9yZWNvcmRf cmluZ3Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJCSAgc3RydWN0IGRybV9pOTE1X2Vy cm9yX3N0YXRlICplcnJvcikKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAq cmVxdWVzdDsKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwgKnRtcHJl cTsKPiAgCWludCBpLCBjb3VudDsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgSTkxNV9OVU1fUklO R1M7IGkrKykgewo+IEBAIC0xMDU1LDcgKzEwNTUsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9y ZWNvcmRfcmluZ3Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQlpOTE1X2dlbV9yZWNvcmRf YWN0aXZlX2NvbnRleHQocmluZywgZXJyb3IsICZlcnJvci0+cmluZ1tpXSk7Cj4gIAo+ICAJCWNv dW50ID0gMDsKPiAtCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcXVlc3QsICZyaW5nLT5yZXF1ZXN0 X2xpc3QsIGxpc3QpCj4gKwkJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHJlcXVlc3QsIHRtcHJl cSwgJnJpbmctPnJlcXVlc3RfbGlzdCwgbGlzdCkKPiAgCQkJY291bnQrKzsKPiAgCj4gIAkJZXJy b3ItPnJpbmdbaV0ubnVtX3JlcXVlc3RzID0gY291bnQ7Cj4gQEAgLTEwNjgsNyArMTA2OCw3IEBA IHN0YXRpYyB2b2lkIGk5MTVfZ2VtX3JlY29yZF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ICAJCX0KPiAgCj4gIAkJY291bnQgPSAwOwo+IC0JCWxpc3RfZm9yX2VhY2hfZW50cnkocmVx dWVzdCwgJnJpbmctPnJlcXVlc3RfbGlzdCwgbGlzdCkgewo+ICsJCWxpc3RfZm9yX2VhY2hfZW50 cnlfc2FmZShyZXF1ZXN0LCB0bXByZXEsICZyaW5nLT5yZXF1ZXN0X2xpc3QsIGxpc3QpIHsKPiAg CQkJc3RydWN0IGRybV9pOTE1X2Vycm9yX3JlcXVlc3QgKmVycTsKPiAgCj4gIAkJCWVycSA9ICZl cnJvci0+cmluZ1tpXS5yZXF1ZXN0c1tjb3VudCsrXTsKPiBAQCAtMTA4OCwxNyArMTA4OCwxNyBA QCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9jYXB0dXJlX3ZtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgCQkJCWNvbnN0IGludCBuZHgpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkx NV9lcnJvcl9idWZmZXIgKmFjdGl2ZV9ibyA9IE5VTEwsICpwaW5uZWRfYm8gPSBOVUxMOwo+IC0J c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAtCXN0cnVjdCBpOTE1X3ZtYSAqdm1h Owo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgKnRtcG9iajsKPiArCXN0cnVj dCBpOTE1X3ZtYSAqdm1hLCAqdG1wdm1hOwo+ICAJaW50IGk7Cj4gIAo+ICAJaSA9IDA7Cj4gLQls aXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgJnZtLT5hY3RpdmVfbGlzdCwgbW1fbGlzdCkKPiArCWxp c3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2bWEsIHRtcHZtYSwgJnZtLT5hY3RpdmVfbGlzdCwgbW1f bGlzdCkKPiAgCQlpKys7Cj4gIAllcnJvci0+YWN0aXZlX2JvX2NvdW50W25keF0gPSBpOwo+ICAK PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkob2JqLCAmZGV2X3ByaXYtPm1tLmJvdW5kX2xpc3QsIGds b2JhbF9saXN0KSB7Cj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRyeSh2bWEsICZvYmotPnZtYV9saXN0 LCB2bWFfbGluaykKPiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShvYmosIHRtcG9iaiwgJmRl dl9wcml2LT5tbS5ib3VuZF9saXN0LCBnbG9iYWxfbGlzdCkgewo+ICsJCWxpc3RfZm9yX2VhY2hf ZW50cnlfc2FmZSh2bWEsIHRtcHZtYSwgJm9iai0+dm1hX2xpc3QsIHZtYV9saW5rKQo+ICAJCQlp ZiAodm1hLT52bSA9PSB2bSAmJiB2bWEtPnBpbl9jb3VudCA+IDApCj4gIAkJCQlpKys7Cj4gIAl9 Cj4gQEAgLTExMjgsMTAgKzExMjgsMTAgQEAgc3RhdGljIHZvaWQgaTkxNV9nZW1fY2FwdHVyZV92 bShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIHN0YXRpYyB2b2lkIGk5MTVf Z2VtX2NhcHR1cmVfYnVmZmVycyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g IAkJCQkgICAgIHN0cnVjdCBkcm1faTkxNV9lcnJvcl9zdGF0ZSAqZXJyb3IpCj4gIHsKPiAtCXN0 cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtOwo+ICsJc3RydWN0IGk5MTVfYWRkcmVzc19zcGFj ZSAqdm0sICp0bXB2bTsKPiAgCWludCBjbnQgPSAwLCBpID0gMDsKPiAgCj4gLQlsaXN0X2Zvcl9l YWNoX2VudHJ5KHZtLCAmZGV2X3ByaXYtPnZtX2xpc3QsIGdsb2JhbF9saW5rKQo+ICsJbGlzdF9m b3JfZWFjaF9lbnRyeV9zYWZlKHZtLCB0bXB2bSwgJmRldl9wcml2LT52bV9saXN0LCBnbG9iYWxf bGluaykKPiAgCQljbnQrKzsKPiAgCj4gIAllcnJvci0+YWN0aXZlX2JvID0ga2NhbGxvYyhjbnQs IHNpemVvZigqZXJyb3ItPmFjdGl2ZV9ibyksIEdGUF9BVE9NSUMpOwo+IEBAIC0xMTU1LDcgKzEx NTUsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9jYXB0dXJlX2J1ZmZlcnMoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCWVycm9yLT5waW5uZWRfYm8gPSBOVUxMOwo+ICAJ CWVycm9yLT5waW5uZWRfYm9fY291bnQgPSBOVUxMOwo+ICAJfSBlbHNlIHsKPiAtCQlsaXN0X2Zv cl9lYWNoX2VudHJ5KHZtLCAmZGV2X3ByaXYtPnZtX2xpc3QsIGdsb2JhbF9saW5rKQo+ICsJCWxp c3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2bSwgdG1wdm0sICZkZXZfcHJpdi0+dm1fbGlzdCwgZ2xv YmFsX2xpbmspCj4gIAkJCWk5MTVfZ2VtX2NhcHR1cmVfdm0oZGV2X3ByaXYsIGVycm9yLCB2bSwg aSsrKTsKPiAgCj4gIAkJZXJyb3ItPnZtX2NvdW50ID0gY250Owo+IC0tIAo+IDEuOS4xCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=