From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vms173021pub.verizon.net (vms173021pub.verizon.net [206.46.173.21]) by arago-project.org (Postfix) with ESMTPS id D079452979 for ; Fri, 9 Oct 2015 11:49:34 +0000 (UTC) Received: from gandalf.denix.org ([108.51.169.48]) by vms173021.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPSA id <0NVY00AAKBIL3Q90@vms173021.mailsrvcs.net> for meta-arago@arago-project.org; Fri, 09 Oct 2015 06:49:34 -0500 (CDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=MtGvkDue c=1 sm=1 tr=0 a=x3PDphkivVtATbYodTxRAw==:117 a=0gcC27t9AAAA:8 a=oR5dmqMzAAAA:8 a=kj9zAlcOel0A:10 a=5lJygRwiOn0A:10 a=sozttTNsAAAA:8 a=HihYlcsHAAAA:8 a=4OLq8zwGRSa2YljS64gA:9 a=CjuIK1q_8ugA:10 Received: by gandalf.denix.org (Postfix, from userid 1000) id 793FF161C70; Fri, 9 Oct 2015 07:49:33 -0400 (EDT) Date: Fri, 09 Oct 2015 07:49:33 -0400 From: Denys Dmytriyenko To: Jacob Stiffler Message-id: <20151009114933.GF11709@denix.org> References: <1444390383-5586-1-git-send-email-j-stiffler@ti.com> <20151009113618.GE11709@denix.org> <5617A6FF.1090401@ti.com> MIME-version: 1.0 In-reply-to: <5617A6FF.1090401@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-arago@arago-project.org Subject: Re: [PATCH] init-ifupdown: Fix getting DNS if rootfs is network mount X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2015 11:49:35 -0000 Content-type: text/plain; charset=us-ascii Content-disposition: inline On Fri, Oct 09, 2015 at 07:37:35AM -0400, Jacob Stiffler wrote: > > > On 10/9/2015 7:36 AM, Denys Dmytriyenko wrote: > >NAK, this is wrong. > > What is wrong about it? Is there another way to get the DNS addresses? You assume dhcp unconditionally w/o consulting /etc/interfaces file from init-ifupdown > >On Fri, Oct 09, 2015 at 07:33:03AM -0400, Jacob Stiffler wrote: > >>* Previously, if the rootfs was a network mount, then no network > >> configuration was done > >>* This included the DHCP request to obtain the DNS addresses > >>* If the rootfs is a network mount, then run "udhcpc" to get the DNS > >> addresses > >> > >>Signed-off-by: Jacob Stiffler > >>--- > >> meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init | 5 ++++- > >> .../recipes-core/init-ifupdown/init-ifupdown_%.bbappend | 2 +- > >> 2 files changed, 5 insertions(+), 2 deletions(-) > >> > >>diff --git a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init > >>index 86aff88..235652d 100644 > >>--- a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init > >>+++ b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown/init > >>@@ -20,12 +20,15 @@ case "$1" in > >> if sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\1 \2/p' /proc/mounts | > >> grep -q "^/ nfs$"; then > >> echo "NOT configuring network interfaces: / is an NFS mount" > >>+ udhcpc > >> elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\1 \2/p' /proc/mounts | > >> grep -q "^/ smbfs$"; then > >> echo "NOT configuring network interfaces: / is an SMB mount" > >>- elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\2/p' /proc/mounts | > >>+ udhcpc > >>+ elif sed -n 's/^[^ ]* \([^ ]*\) \([^ ]*\) .*$/\2/p' /proc/mounts | > >> grep -qE '^(nfs|smbfs|ncp|coda)$'; then > >> echo "NOT configuring network interfaces: network shares still mounted." > >>+ udhcpc > >> else > >> echo -n "Configuring network interfaces... " > >> ifup -a > >>diff --git a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend > >>index c0ab069..997adf2 100644 > >>--- a/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend > >>+++ b/meta-arago-distro/recipes-core/init-ifupdown/init-ifupdown_%.bbappend > >>@@ -1,4 +1,4 @@ > >> # look for files in this layer first > >> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > >>-PR_append = "-arago0" > >>+PR_append = "-arago1" > >>-- > >>1.9.1 > >> > >>_______________________________________________ > >>meta-arago mailing list > >>meta-arago@arago-project.org > >>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > >> >