From: Shivani Bhardwaj <shivanib134@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info
Date: Fri, 9 Oct 2015 19:51:18 +0530 [thread overview]
Message-ID: <20151009142118.GA57009@ubuntu> (raw)
Replaced the function printk() with dev_info() to fix the warning
generated by checkpatch : printk() should include KERN_ facility level.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
Changes in v2:
-Replaced the function pr_info() with dev_info()
drivers/staging/sm750fb/ddk750_help.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..b877704 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -1,5 +1,7 @@
#include "ddk750_help.h"
+#include <linux/pci.h>
+static struct pci_dev *pdev;
void __iomem *mmio750;
char revId750;
unsigned short devId750;
@@ -11,7 +13,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
devId750 = devId;
revId750 = revId;
if (revId == 0xfe)
- printk("found sm750le\n");
+ dev_info(&pdev->dev, "found sm750le\n");
}
--
2.1.0
next reply other threads:[~2015-10-09 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 14:21 Shivani Bhardwaj [this message]
2015-10-10 7:14 ` [Outreachy kernel] [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info Sudip Mukherjee
2015-10-10 7:24 ` Julia Lawall
2015-10-10 7:38 ` Sudip Mukherjee
2015-10-10 7:40 ` Julia Lawall
2015-10-10 8:07 ` Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2015-10-09 7:30 Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009142118.GA57009@ubuntu \
--to=shivanib134@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.