From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756953AbbJIOys (ORCPT ); Fri, 9 Oct 2015 10:54:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17454 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbbJIOyq (ORCPT ); Fri, 9 Oct 2015 10:54:46 -0400 Date: Fri, 9 Oct 2015 17:54:14 +0300 From: Dan Carpenter To: Tillmann Heidsieck Cc: devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Punit Vara , stillcompiling@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Sudip Mukherjee , Joe Perches , dogukan.ergun@gmail.com, Larry Finger Subject: Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision Message-ID: <20151009145414.GU7340@mwanda> References: <1443286161-3003-1-git-send-email-punitvara@gmail.com> <5606D9CA.1040502@lwfinger.net> <20150928111828.GA10335@sudip-pc> <56095513.4090108@lwfinger.net> <20150929202458.GA4213@themis.lan> <20150930093433.GD7340@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150930093433.GD7340@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 12:34:33PM +0300, Dan Carpenter wrote: > On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > > The primary requirement for moving a driver out of staging is that it use > > > mac80211. No amount of cosmetic fixing will ever make that change for > > > rtl8712u! > > > > As I am pretty sure someone has done something like this before, is > > there a best practice write-up on this? Or a driver that is recommended > > for usage as a template? > > That's a good question. The rtl* drivers are basically a dozen copies > of the same code. I think we have had a few escape from staging? > There have several realtek drivers which have escaped staging. All of them seem to have been re-writes from scratch. Three of them were wifi drivers. rtl8187se: 5ed0a8e66709 ('staging: delete rtl8187se wireless driver') rtl8192ee: f823182bc289 ('staging: r8192ee: Remove staging driver') rtl8821ae: 76272ab3f348 ('staging: rtl8821ae: remove driver') It feels like cleaning up rtl drivers is a waste of time except for the churn. Staging was deliberately designed to encourage churn so that a lot of newbies could get experience sending patches. It would have been easy enough to run new drivers through checkpatch.pl --fix or whatever but churn was part of the point from square one. regards, dan carpenter