From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757377AbbJIPoX (ORCPT ); Fri, 9 Oct 2015 11:44:23 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:58645 "EHLO e37.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbbJIPoW (ORCPT ); Fri, 9 Oct 2015 11:44:22 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 9 Oct 2015 08:44:20 -0700 From: "Paul E. McKenney" To: Christian Borntraeger Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] locktorture: fix wrong parameter handling Message-ID: <20151009154420.GT3910@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1444392885-6691-1-git-send-email-borntraeger@de.ibm.com> <20151009144650.GR3910@linux.vnet.ibm.com> <5617D4FD.3030803@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5617D4FD.3030803@de.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15100915-0025-0000-0000-00001DC36DF0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2015 at 04:53:49PM +0200, Christian Borntraeger wrote: > Am 09.10.2015 um 16:46 schrieb Paul E. McKenney: > > On Fri, Oct 09, 2015 at 02:14:45PM +0200, Christian Borntraeger wrote: > >> Calling locktorture with a wrong parameter makes it > >> unusable: > >> > >> $ modprobe locktorture torture_type=help > >> modprobe: ERROR: could not insert 'locktorture': Invalid argument > >> > >> $ modprobe locktorture torture_type=spin_lock > >> modprobe: ERROR: could not insert 'locktorture': Device or resource busy > >> > >> $ dmesg > >> [...] > >> torture_init_begin: refusing spin_lock init: help running > >> > >> We can easily do the checking before call into the torture framework. > >> > >> Signed-off-by: Christian Borntraeger > > > > Good catch, thank you! > > > > Could you please port this to rcu/next in the -rcu tree? Also, please > > capitalize the word following the ":" in the subject line, as in "[PATCH] > > locktorture: Fix wrong parameter handling". > > Hmmm, seems that this is already fixed in rcu/next with > > commit a36a99618b1adb2d6ca0b7e08e3a656a04e477fe > Author: Paul E. McKenney > AuthorDate: Sun Aug 30 20:01:48 2015 -0700 > Commit: Paul E. McKenney > CommitDate: Tue Oct 6 11:28:44 2015 -0700 > > locktorture: Fix module unwind when bad torture_type specified > > > No need to respin a patch it seems :-) Works for me! ;-) Thanx, Paul