From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 9 Oct 2015 13:59:45 -0400 From: Jon Mason To: Stephen Boyd CC: Michael Turquette , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , , , , , Subject: Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC Message-ID: <20151009175945.GB17527@broadcom.com> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-3-git-send-email-jonmason@broadcom.com> <20151009073746.GP26883@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20151009073746.GP26883@codeaurora.org> Return-Path: jonmason@broadcom.com List-ID: On Fri, Oct 09, 2015 at 12:37:46AM -0700, Stephen Boyd wrote: > On 10/02, Jon Mason wrote: > > diff --git a/drivers/clk/bcm/clk-nsp.c b/drivers/clk/bcm/clk-nsp.c > > new file mode 100644 > > index 0000000..708961a > > --- /dev/null > > +++ b/drivers/clk/bcm/clk-nsp.c > > @@ -0,0 +1,139 @@ > > +/* > > + * Copyright (C) 2015 Broadcom Corporation > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation version 2. > > + * > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > > + * kind, whether express or implied; without even the implied warranty > > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Is this used? > > > +#include > > +#include > > Is this used? I removed the clkdev and delay headers, and it appears to be working fine without them. I'll rework this commit and resubmit. Thanks, Jon > > > + > > +#include > > +#include "clk-iproc.h" > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: jonmason@broadcom.com (Jon Mason) Date: Fri, 9 Oct 2015 13:59:45 -0400 Subject: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC In-Reply-To: <20151009073746.GP26883@codeaurora.org> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-3-git-send-email-jonmason@broadcom.com> <20151009073746.GP26883@codeaurora.org> Message-ID: <20151009175945.GB17527@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 09, 2015 at 12:37:46AM -0700, Stephen Boyd wrote: > On 10/02, Jon Mason wrote: > > diff --git a/drivers/clk/bcm/clk-nsp.c b/drivers/clk/bcm/clk-nsp.c > > new file mode 100644 > > index 0000000..708961a > > --- /dev/null > > +++ b/drivers/clk/bcm/clk-nsp.c > > @@ -0,0 +1,139 @@ > > +/* > > + * Copyright (C) 2015 Broadcom Corporation > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation version 2. > > + * > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > > + * kind, whether express or implied; without even the implied warranty > > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Is this used? > > > +#include > > +#include > > Is this used? I removed the clkdev and delay headers, and it appears to be working fine without them. I'll rework this commit and resubmit. Thanks, Jon > > > + > > +#include > > +#include "clk-iproc.h" > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Mason Subject: Re: [PATCH 02/10] clk: nsp: add clock support for Broadcom Northstar Plus SoC Date: Fri, 9 Oct 2015 13:59:45 -0400 Message-ID: <20151009175945.GB17527@broadcom.com> References: <1443826665-17570-1-git-send-email-jonmason@broadcom.com> <1443826665-17570-3-git-send-email-jonmason@broadcom.com> <20151009073746.GP26883@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20151009073746.GP26883@codeaurora.org> Sender: linux-clk-owner@vger.kernel.org To: Stephen Boyd Cc: Michael Turquette , Florian Fainelli , Hauke Mehrtens , Ray Jui , Scott Branden , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com List-Id: devicetree@vger.kernel.org On Fri, Oct 09, 2015 at 12:37:46AM -0700, Stephen Boyd wrote: > On 10/02, Jon Mason wrote: > > diff --git a/drivers/clk/bcm/clk-nsp.c b/drivers/clk/bcm/clk-nsp.c > > new file mode 100644 > > index 0000000..708961a > > --- /dev/null > > +++ b/drivers/clk/bcm/clk-nsp.c > > @@ -0,0 +1,139 @@ > > +/* > > + * Copyright (C) 2015 Broadcom Corporation > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation version 2. > > + * > > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > > + * kind, whether express or implied; without even the implied warranty > > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Is this used? > > > +#include > > +#include > > Is this used? I removed the clkdev and delay headers, and it appears to be working fine without them. I'll rework this commit and resubmit. Thanks, Jon > > > + > > +#include > > +#include "clk-iproc.h" > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project