From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/3] python-numpy: introduce ARCH_SUPPORTS hidden variable
Date: Fri, 9 Oct 2015 22:55:34 +0200 [thread overview]
Message-ID: <20151009225534.5a507232@free-electrons.com> (raw)
In-Reply-To: <1444203799-16230-1-git-send-email-gwenj@trabucayre.com>
Gwenhael,
On Wed, 7 Oct 2015 09:43:17 +0200, Gwenhael Goavec-Merou wrote:
> diff --git a/package/python-numpy/Config.in b/package/python-numpy/Config.in
> index f8170f8..f25102a 100644
> --- a/package/python-numpy/Config.in
> +++ b/package/python-numpy/Config.in
> @@ -1,9 +1,13 @@
> -config BR2_PACKAGE_PYTHON_NUMPY
> - bool "python-numpy"
> +config BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
> + bool
> # Numpy has some CPU specific code
> depends on BR2_aarch64 || BR2_arm || BR2_armeb || BR2_i386 \
> || BR2_mips || BR2_mipsel || BR2_powerpc || BR2_powerpc64 \
> || BR2_sh || BR2_x86_64
With this code, the BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS option is
always false: there is nothing that makes it equal to 'y', so I don't
see how you could test these patches.
So I've fixed that by replacing:
depends on BR2_aarch64 ...
by:
default y if BR2_aarch64 ...
And applied.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-10-09 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 7:43 [Buildroot] [PATCH v6 1/3] python-numpy: introduce ARCH_SUPPORTS hidden variable Gwenhael Goavec-Merou
2015-10-07 7:43 ` [Buildroot] [PATCH v6 2/3] opencv3: use BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS instead of replicate python-numpy depends Gwenhael Goavec-Merou
2015-10-07 8:36 ` Samuel Martin
2015-10-09 21:00 ` Thomas Petazzoni
2015-10-07 7:43 ` [Buildroot] [PATCH v6 3/3] gnuradio: gnuradio-python gnuradio-utils: add missing dependency to python-numpy Gwenhael Goavec-Merou
2015-10-07 8:38 ` Samuel Martin
2015-10-09 21:00 ` Thomas Petazzoni
2015-10-09 21:31 ` Thomas Petazzoni
2015-10-07 8:37 ` [Buildroot] [PATCH v6 1/3] python-numpy: introduce ARCH_SUPPORTS hidden variable Samuel Martin
2015-10-07 11:59 ` Vicente Olivert Riera
2015-10-07 12:25 ` gwenhael.goavec
2015-10-09 20:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009225534.5a507232@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.