From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 3/3] nvme: refactor nvme_queue_rq
Date: Sat, 10 Oct 2015 08:53:19 +0200 [thread overview]
Message-ID: <20151010065319.GA17885@lst.de> (raw)
In-Reply-To: <20151009201154.GA29924@localhost.localdomain>
On Fri, Oct 09, 2015@02:11:54PM -0600, Jon Derrick wrote:
> Hi Christoph,
>
> > + if (!nvme_setup_prps(dev, iod, blk_rq_bytes(req)))
> > + goto out_unmap;
> Git am complains about whitespacing here.
Hmm, checkpatch was fine with it. I know there was odd whitespacing on
the lines before I touched i but I though I fixed all that.
> The set looks fine to me. I'm tempted to do some performance testing with the microoptimizations present here. Have you seen any results yourself?
On the PCIe side I've only tested it with normal Flash devices where
I didn't see a difference, so numbers would be welcome.
next prev parent reply other threads:[~2015-10-10 6:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 16:55 nvme ->queue_rq updates Christoph Hellwig
2015-10-09 16:55 ` [PATCH 1/3] nvme: add missing unmaps in nvme_queue_rq Christoph Hellwig
2015-10-09 16:55 ` Christoph Hellwig
2015-10-09 23:46 ` Sagi Grimberg
2015-10-09 23:46 ` Sagi Grimberg
2015-10-10 6:55 ` Christoph Hellwig
2015-10-10 6:55 ` Christoph Hellwig
2015-10-09 16:55 ` [PATCH 2/3] nvme: simplify nvme_setup_prps calling convention Christoph Hellwig
2015-10-09 16:55 ` [PATCH 3/3] nvme: refactor nvme_queue_rq Christoph Hellwig
2015-10-09 20:11 ` Jon Derrick
2015-10-10 6:53 ` Christoph Hellwig [this message]
2015-10-10 7:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010065319.GA17885@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.