From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6203546917110022144 X-Received: by 10.13.215.73 with SMTP id z70mr14162350ywd.23.1444461288540; Sat, 10 Oct 2015 00:14:48 -0700 (PDT) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.18.98 with SMTP id a95ls328502ioj.25.gmail; Sat, 10 Oct 2015 00:14:48 -0700 (PDT) X-Received: by 10.66.227.166 with SMTP id sb6mr14468255pac.0.1444461288219; Sat, 10 Oct 2015 00:14:48 -0700 (PDT) Return-Path: Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com. [2607:f8b0:400e:c03::22c]) by gmr-mx.google.com with ESMTPS id uv4si638854pac.0.2015.10.10.00.14.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Oct 2015 00:14:48 -0700 (PDT) Received-SPF: pass (google.com: domain of sudipm.mukherjee@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) client-ip=2607:f8b0:400e:c03::22c; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of sudipm.mukherjee@gmail.com designates 2607:f8b0:400e:c03::22c as permitted sender) smtp.mailfrom=sudipm.mukherjee@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com Received: by mail-pa0-x22c.google.com with SMTP id lk4so106969906pab.3 for ; Sat, 10 Oct 2015 00:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=t2zT8H0SHvOO/ovoSXirCwoVe3eTAhAAJGfIdVKYiEE=; b=j+KepoF1i5aVA7yyaGwRTfC/0EiAUH8nkdTt1ODox3eSbRwIoPuccJaJoUulCdFzEW FQASD1SWKywCVfEgA3mDP5IHJjnecGcIpsMGeI3MRMYZIqNJxAxCuyaJEwB8bocdBbdc MOCu4wZ4thal5fBjiZOPSsZW+UIBlX7gYYVZJEw5KQYpwtAy0Z+w32uNem6w1fDST0Dj V5ClfWwzEvUOMaYNkt1yuVf4QFd7BIFeRSoa99HXKruZbz1PCXETnihC2W4X34S93Svp BZEzOwh3OK6GKk4DfNJNiNQLocnhwkrxvClw1x27sH6/jboW0sRct+h0AcZ9O3r+4aN4 LILw== X-Received: by 10.66.147.74 with SMTP id ti10mr20621705pab.88.1444461288101; Sat, 10 Oct 2015 00:14:48 -0700 (PDT) Return-Path: Received: from sudip-pc ([49.206.251.3]) by smtp.gmail.com with ESMTPSA id or6sm6330251pac.32.2015.10.10.00.14.46 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 10 Oct 2015 00:14:47 -0700 (PDT) Date: Sat, 10 Oct 2015 12:44:43 +0530 From: Sudip Mukherjee To: Shivani Bhardwaj Cc: outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] Staging: sm750fb: ddk750_help: Included KERN_facility level using dev_info Message-ID: <20151010071443.GC4795@sudip-pc> References: <20151009142118.GA57009@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151009142118.GA57009@ubuntu> User-Agent: Mutt/1.5.21 (2010-09-15) On Fri, Oct 09, 2015 at 07:51:18PM +0530, Shivani Bhardwaj wrote: > Replaced the function printk() with dev_info() to fix the warning > generated by checkpatch : printk() should include KERN_ facility level. > > Signed-off-by: Shivani Bhardwaj > --- > Changes in v2: > -Replaced the function pr_info() with dev_info() > > drivers/staging/sm750fb/ddk750_help.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c > index 9637dd3..b877704 100644 > --- a/drivers/staging/sm750fb/ddk750_help.c > +++ b/drivers/staging/sm750fb/ddk750_help.c > @@ -1,5 +1,7 @@ > #include "ddk750_help.h" > +#include > > +static struct pci_dev *pdev; > void __iomem *mmio750; > char revId750; > unsigned short devId750; > @@ -11,7 +13,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > devId750 = devId; > revId750 = revId; > if (revId == 0xfe) > - printk("found sm750le\n"); > + dev_info(&pdev->dev, "found sm750le\n"); OOPS .. no.. pdev is initialized to NULL, so when you do pdev->dev, you are doing a dereference of NULL pointer. regards sudip