All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alison Schofield <amsfield22@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rdma: hfi1: remove unnecessary 'out of memory' messages
Date: Sat, 10 Oct 2015 13:52:44 +0530	[thread overview]
Message-ID: <20151010082244.GI4795@sudip-pc> (raw)
In-Reply-To: <20151010044521.GA27086@Ubuntu-D830>

On Fri, Oct 09, 2015 at 09:45:34PM -0700, Alison Schofield wrote:
> 'Out of memory' messages are unnecssary in the drivers as they are
> reported by memory management.
> 
> Addresses checkpatch.pl: WARNING: Possible unnecessary 'out of memory' message
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> ---
<snip>
> diff --git a/drivers/staging/rdma/hfi1/user_sdma.c b/drivers/staging/rdma/hfi1/user_sdma.c
> index 6620262..b20cbb9 100644
> --- a/drivers/staging/rdma/hfi1/user_sdma.c
> +++ b/drivers/staging/rdma/hfi1/user_sdma.c
> @@ -378,20 +378,14 @@ int hfi1_user_sdma_alloc_queues(struct hfi1_ctxtdata *uctxt, struct file *fp)
>  	dd = uctxt->dd;
>  
>  	pq = kzalloc(sizeof(*pq), GFP_KERNEL);
> -	if (!pq) {
> -		dd_dev_err(dd,
> -			   "[%u:%u] Failed to allocate SDMA request struct\n",
> -			   uctxt->ctxt, subctxt_fp(fp));
> +	if (!pq)
>  		goto pq_nomem;
> -	}
> +
>  	memsize = sizeof(*pq->reqs) * hfi1_sdma_comp_ring_size;
>  	pq->reqs = kmalloc(memsize, GFP_KERNEL);
> -	if (!pq->reqs) {
> -		dd_dev_err(dd,
> -			   "[%u:%u] Failed to allocate SDMA request queue (%u)\n",
> -			   uctxt->ctxt, subctxt_fp(fp), memsize);
> +	if (!pq->reqs) 

trailing whitespace error here.

regards
sudip


  parent reply	other threads:[~2015-10-10  8:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10  4:45 [PATCH] staging: rdma: hfi1: remove unnecessary 'out of memory' messages Alison Schofield
2015-10-10  5:53 ` [Outreachy kernel] " Julia Lawall
2015-10-10 17:13   ` Alison Schofield
2015-10-10 17:31     ` Julia Lawall
2015-10-10  8:22 ` Sudip Mukherjee [this message]
2015-10-12 21:28 ` [PATCH v2] staging: rdma: hfi1: remove unnecessary out of memory messages Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151010082244.GI4795@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=amsfield22@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.