From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] bash: add default bash settings
Date: Sat, 10 Oct 2015 11:54:03 +0200 [thread overview]
Message-ID: <20151010115403.7cf295f0@free-electrons.com> (raw)
In-Reply-To: <1444259824-6246-1-git-send-email-dvanarnem@cmlab.biz>
Dear David Van Arnem,
On Wed, 7 Oct 2015 17:17:04 -0600, David Van Arnem wrote:
> Settings that were bash-specific were previously removed from
> system/skeleton/etc/profile. This measn that users using bash no longer
> get the "normal" bash prompt with [user at host dir]#/$, and only get #/$.
> This commit adds back the bash-specific settings, but adds them to the
> bash package so they are only used when bash is installed on the target
> system.
>
> bash_profile.sh contains the variables, aliases, and color profile that
> were previously in system/skeleton/etc/profile. The changes to bash.mk
> use a post-install hook to install bash_profile.sh to the target
> filesystem, where it will later be sourced by /etc/profile when a bash
> shell is started.
>
> Signed-off-by: David Van Arnem <dvanarnem@cmlab.biz>
Thanks for your patch. Following the comments from Maxime Hadjinlian on
your patch, I've marked it as "Changes Requested" in our patch tracking
system. Please resubmit a new version of your patch that takes into
account the comments made by Maxime. Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-10 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 23:17 [Buildroot] [PATCH 1/1] bash: add default bash settings David Van Arnem
2015-10-08 9:02 ` Maxime Hadjinlian
2015-10-10 9:54 ` Thomas Petazzoni [this message]
2015-10-12 16:55 ` David Van Arnem
2015-10-12 16:57 ` David Van Arnem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010115403.7cf295f0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.