From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 10 Oct 2015 21:08:02 +0000 Subject: Re: [PATCH 5/5] arm: add missing of_node_put Message-Id: <20151010230802.71d1c421@free-electrons.com> List-Id: References: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr> <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr> <8655275.vMqHQfLN9g@wuerfel> In-Reply-To: <8655275.vMqHQfLN9g@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Arnd, On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > The same for_each_child_of_node() loop has three 'return' statements' > aside from the 'break' statement here. I think you should change your > semantic patch to cover both cases. I think Julia's semantic patch covers both cases, but only the cases where there is one break or return (though I have essentially zero Coccinelle knowledge, this is all based on guessing looking at the semantic patch in the cover letter). Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) Date: Sat, 10 Oct 2015 23:08:02 +0200 Subject: [PATCH 5/5] arm: add missing of_node_put In-Reply-To: <8655275.vMqHQfLN9g@wuerfel> References: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr> <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr> <8655275.vMqHQfLN9g@wuerfel> Message-ID: <20151010230802.71d1c421@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd, On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > The same for_each_child_of_node() loop has three 'return' statements' > aside from the 'break' statement here. I think you should change your > semantic patch to cover both cases. I think Julia's semantic patch covers both cases, but only the cases where there is one break or return (though I have essentially zero Coccinelle knowledge, this is all based on guessing looking at the semantic patch in the cover letter). Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbbJJVIJ (ORCPT ); Sat, 10 Oct 2015 17:08:09 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49037 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751433AbbJJVII (ORCPT ); Sat, 10 Oct 2015 17:08:08 -0400 Date: Sat, 10 Oct 2015 23:08:02 +0200 From: Thomas Petazzoni To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Julia Lawall , Russell King , Andrew Lunn , Jason Cooper , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 5/5] arm: add missing of_node_put Message-ID: <20151010230802.71d1c421@free-electrons.com> In-Reply-To: <8655275.vMqHQfLN9g@wuerfel> References: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr> <1444480254-14399-6-git-send-email-Julia.Lawall@lip6.fr> <8655275.vMqHQfLN9g@wuerfel> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, On Sat, 10 Oct 2015 23:02:15 +0200, Arnd Bergmann wrote: > The same for_each_child_of_node() loop has three 'return' statements' > aside from the 'break' statement here. I think you should change your > semantic patch to cover both cases. I think Julia's semantic patch covers both cases, but only the cases where there is one break or return (though I have essentially zero Coccinelle knowledge, this is all based on guessing looking at the semantic patch in the cover letter). Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com