From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Xenomai <xenomai@xenomai.org>
Subject: [Xenomai] Issue with CONFIG_PREEMPT_VOLUNTARY
Date: Sun, 11 Oct 2015 15:05:36 +0200 [thread overview]
Message-ID: <20151011130536.GA1765@hermes.click-hack.org> (raw)
Hi,
It seems commit fdb5d54d04b8c3b6b6a6ad7ac2b6248cf0b415e0 in the
I-pipe kernels cause a warning when CONFIG_PREEMPT_VOLUNTARY and
CONFIG_IPIPE_DEBUG_INTERNAL are enabled. The culprit is the call to
__ipipe_root_p.
The following patch avoids this warning:
diff --git a/kernel/ipipe/core.c b/kernel/ipipe/core.c
index 0320453..a5e440d 100644
--- a/kernel/ipipe/core.c
+++ b/kernel/ipipe/core.c
@@ -1730,17 +1730,19 @@ int notrace __ipipe_check_percpu_access(void)
if (raw_irqs_disabled_flags(flags))
goto out;
+ if (!IS_ENABLED(CONFIG_PREEMPT_COUNT))
+ goto out;
+
/*
* Last chance: hw interrupts were enabled on entry while
* running over the root domain, but the root stage might be
* currently stalled, in which case preemption would be
* disabled, and no migration could occur.
*/
- if (this_domain == ipipe_root_domain) {
- p = raw_cpu_ptr(&ipipe_percpu.root);
- if (test_bit(IPIPE_STALL_FLAG, &p->status) || preempt_count())
+
+ p = raw_cpu_ptr(&ipipe_percpu.root);
+ if (test_bit(IPIPE_STALL_FLAG, &p->status) || preempt_count())
goto out;
- }
/*
* Our caller may end up accessing the wrong per-cpu variable
* instance due to CPU migration; tell it to complain about
--
Gilles.
https://click-hack.org
next reply other threads:[~2015-10-11 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 13:05 Gilles Chanteperdrix [this message]
2015-10-12 7:23 ` [Xenomai] Issue with CONFIG_PREEMPT_VOLUNTARY Jan Kiszka
2015-10-12 8:10 ` Gilles Chanteperdrix
2015-10-12 8:37 ` Jan Kiszka
2015-10-12 8:48 ` Gilles Chanteperdrix
2015-10-12 8:58 ` Jan Kiszka
2015-10-12 17:40 ` [Xenomai] [PATCH 1/2] ipipe: simplify __ipipe_check_perccpu_access() Gilles Chanteperdrix
2015-10-12 17:40 ` [Xenomai] [PATCH 2/2] ipipe: fix __ipipe_check_percpu_access() Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151011130536.GA1765@hermes.click-hack.org \
--to=gilles.chanteperdrix@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.